[PATCH 2/3] qemu: Always assume support for QEMU_CAPS_IDE_DRIVE_WWN

Peter Krempa pkrempa at redhat.com
Tue Jul 18 13:57:06 UTC 2023


The support for configuring the 'wwn' of a IDE disk was added in qemu
commit 95ebda85e09 (v1.0-1869-g95ebda85e0) and can't be compiled
out.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_validate.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 56fd562b70..03a35bbef6 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -2852,14 +2852,6 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDomainDiskDef *disk,
                            _("Only ide and scsi disk support wwn"));
             return -1;
         }
-
-        if (disk->bus == VIR_DOMAIN_DISK_BUS_IDE &&
-            !virQEMUCapsGet(qemuCaps, QEMU_CAPS_IDE_DRIVE_WWN)) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                           _("Setting wwn for ide disk is not supported "
-                             "by this QEMU"));
-            return -1;
-        }
     }

     if (disk->vendor || disk->product) {
-- 
2.41.0



More information about the libvir-list mailing list