[libvirt PATCH 2/9] src: remote deps on ip[6]tables/firewalld.service from systemd units

[Peter Krempa]

On Wed, Jun 21, 2023 at 14:32:25 +0100, Daniel P. Berrangé wrote:
> The unit files both have After=network.target, and this in turn implies
> After=network-pre.target. Both iptables.service & ip6tables.service have
> Before=network-pre.target since Fedora >= 35 and RHEL >= 8.4.

Is this also true for ubuntu 20.04?

> When we first added the deps on ip[6]tables.service in
> 
>   commit 0756415f147dda15a417bd79eef9a62027d176e6
>   Author: Laine Stump <laine at redhat.com>
>   Date:   Fri May 1 00:05:50 2020 -0400
> 
>     systemd: start libvirtd after firewalld/iptables services
> 
> the Before=network-pre.target didn't exist, but we can rely on it now
> given our supported platforms matrix.
> 
> The firewalld.service has similarly has a Before=network-pre.target,
> even when we took that commit above, so this dep was in face never
> actually needed. This answers the question posed in that above commit
> message about firewalld ordering.
> 
> https://gitlab.com/libvirt/libvirt/-/issues/489
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/network/virtnetworkd.service.in | 3 ---
>  src/remote/libvirtd.service.in      | 3 ---
>  2 files changed, 6 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>