[libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS
Daniel P. Berrangé
berrange at redhat.com
Thu Mar 2 20:04:15 UTC 2023
On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote:
> It is quite confusing seeing these two in a call like this one:
> $ meson build $MESON_OPTS $MESON_ARGS
>
> One has to ask 'how are they different' and 'shouldn't these be
> merged'. In fact, these variables hold very different things and we
> should make it more obvious. The problem is that renaming MESON_OPTS to
> something more meaningful, like 'MESON_CROSS_OPTS' which is what
> MESON_OPTS really does would require changes to lcitool and would
> impact Dockerfile generation which in turn might have an impact on
> other projects which rely on this lcitool functionality which is risky.
>
> Instead, provide a docstring for the former tu supplement the latter
s/tu/to/
> and join the two variables in a single one MESON_ARGS which is then
> passed to meson's command line so it's a little less confusing.
>
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
> ci/build.sh | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list