[libvirt PATCH] docs: Fix broken link to Windows MSI downloads

Kashyap Chamarthy kchamart at redhat.com
Tue May 16 08:16:45 UTC 2023


On Mon, May 15, 2023 at 04:02:12PM +0100, Daniel P. Berrangé wrote:
> On Mon, May 15, 2023 at 04:47:54PM +0200, Kashyap Chamarthy wrote:
> > On Mon, May 15, 2023 at 04:41:12PM +0200, Kashyap Chamarthy wrote:
> > > Right now the URL is 404 due to missing .html.
> > 
> > To think of it, should we instead redirect to the below URL?
> > 
> >     https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/
> > 
> > It has 'qemu-ga" MSI files here:
> > 
> >     https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-qemu-ga/qemu-ga-win-105.0.2-1.el9/
> > 
> >     https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-qemu-ga/
> > 
> > (And also various virtio-win drivers.)
> 
> That doesn't have the Windows DLLs of libvirt in it though, so doesn't
> answer the starting premise of this doc.

Ah, my bad; thanks for the clarification.

> 
> People do probably want the QGA MSI, but that's a separate questionf

Should an additional sentence as below be added to the doc, then?

    The MSI file for QEMU guest agent can be downloaded from here[URL].

> > > Reported by: Sebastien Wains <swains at redhat.com>
> > > 
> > > Signed-off-by: Kashyap Chamarthy <kchamart at redhat.com>
> > > ---
> > >  docs/windows.html.in | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/docs/windows.html.in b/docs/windows.html.in
> > > index 0f2d9061c4..561c08cfa1 100644
> > > --- a/docs/windows.html.in
> > > +++ b/docs/windows.html.in
> > > @@ -17,7 +17,7 @@
> > >      <p>
> > >        Users who need pre-built Windows DLLs of libvirt are advised
> > >        to use the <a href="https://virt-manager.org">Virt Viewer</a>
> > > -      pre-compiled <a href="https://virt-manager.org/download/">Windows MSI packages</a>
> > > +      pre-compiled <a href="https://virt-manager.org/download.html">Windows MSI packages</a>
> > >      </p>
> > >  
> > >      <p>
> > > -- 
> > > 2.40.0
> > > 
> > 
> > -- 
> > /kashyap
> > 
> 
> With regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> 

-- 
/kashyap


More information about the libvir-list mailing list