[PATCH v6 04/11] scripts/qapi: document the tool that generated the file

Alex Bennée alex.bennee at linaro.org
Fri May 26 16:53:54 UTC 2023


This makes it a little easier for developers to find where things
where being generated.

Reviewed-by: Richard Henderson <richard.henderson at linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd at linaro.org>
Reviewed-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Alex Bennée <alex.bennee at linaro.org>
Message-Id: <20230524133952.3971948-5-alex.bennee at linaro.org>

---
v6
  - use Markus' suggestion for prettier wrapping lines
  - drop un-needed str()
---
 scripts/qapi/gen.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index 8f8f784f4a..70bc576a10 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -13,6 +13,7 @@
 
 from contextlib import contextmanager
 import os
+import sys
 import re
 from typing import (
     Dict,
@@ -162,7 +163,7 @@ def __init__(self, fname: str, blurb: str, pydoc: str):
 
     def _top(self) -> str:
         return mcgen('''
-/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
+/* AUTOMATICALLY GENERATED by %(tool)s DO NOT MODIFY */
 
 /*
 %(blurb)s
@@ -174,6 +175,7 @@ def _top(self) -> str:
  */
 
 ''',
+                     tool=os.path.basename(sys.argv[0]),
                      blurb=self._blurb, copyright=self._copyright)
 
     def _bottom(self) -> str:
@@ -195,7 +197,10 @@ def _bottom(self) -> str:
 
 class QAPIGenTrace(QAPIGen):
     def _top(self) -> str:
-        return super()._top() + '# AUTOMATICALLY GENERATED, DO NOT MODIFY\n\n'
+        return (super()._top()
+                + '# AUTOMATICALLY GENERATED by '
+                + os.path.basename(sys.argv[0])
+                + ', DO NOT MODIFY\n\n')
 
 
 @contextmanager
-- 
2.39.2



More information about the libvir-list mailing list