<br><font size=2 face="Courier New">I cannot see the bug in virParseXMLDevice. The 'error' label sequence is ended by 'goto cleanup', and 'cleanup' sequence calls xmlFreeDoc(xml). Is it not the way to free the xmlDocPtr object 'xml'?</font>
<br><font size=2 face="Courier New">Maybe I should reverse the sequence order to be more clear, as follows:</font>
<br><font size=2 face="Courier New">+ goto cleanup;</font>
<br><font size=2 face="Courier New">+error:</font>
<br><font size=2 face="Courier New">+ free(buf.content);</font>
<br><font size=2 face="Courier New">+ buf.content = NULL;</font>
<br><font size=2 face="Courier New">+cleanup:</font>
<br><font size=2 face="Courier New">+ if (xml != NULL)</font>
<br><font size=2 face="Courier New">+ xmlFreeDoc(xml);</font>
<br><font size=2 face="Courier New">+ return buf.content;</font>
<br>
<br>
<table width=100%>
<tr valign=top>
<td>
<td><font size=1 face="sans-serif"><b>"Daniel P. Berrange" <berrange@redhat.com></b></font>
<p><font size=1 face="sans-serif">14/11/2006 19:36</font>
<br><font size=1 face="sans-serif">Veuillez répondre à "Daniel P. Berrange"</font>
<br>
<td><font size=1 face="Arial"> </font>
<br><font size=1 face="sans-serif"> Pour : michel.ponceau@bull.net</font>
<br><font size=1 face="sans-serif"> cc : libvir-list@redhat.com</font>
<br><font size=1 face="sans-serif"> Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain</font></table>
<br>
<br><font size=2 face="Courier New">On Tue, Nov 14, 2006 at 03:34:05PM +0100, michel.ponceau@bull.net wrote:<br>
> This patch adds to Libvirt-0.1.8 the two functions described in my <br>
> preceding mail. It has been tested in our Bull environment.<br>
<br>
This looks good to me - only one small bug I see - in the virParseXMLDevice<br>
function there is a memory leak. If you take 'goto errror' path through<br>
the function, then the xmlDocPtr object will never be free'd. Thanks for<br>
taking the time to implement all this !<br>
<br>
Regards,<br>
Dan.<br>
-- <br>
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|<br>
|=- Perl modules: http://search.cpan.org/~danberr/ -=|<br>
|=- Projects: http://freshmeat.net/~danielpb/ -=|<br>
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| <br>
</font>
<br>