<br><font size=2 face="Courier New">There is a bug in GetNetworkID(): return(ret) with ret=list[i], after free(list). It leads to process abort on free(xref) in caller </font><font size=2><tt>XMLDevID</tt></font><font size=2 face="Courier New">(). I corrected this by replacing:</font>
<br><font size=2 face="Courier New"> ret = list[i];</font>
<br><font size=2 face="Courier New">by:</font>
<br><font size=2 face="Courier New"> ret = malloc(16);</font>
<br><font size=2 face="Courier New"> if (ret != NULL) strcpy(ret, list[i]);</font>
<br><font size=2 face="Courier New">Our tests were successful afterwards.</font>
<br>
<br>
<table width=100%>
<tr valign=top>
<td>
<td><font size=1 face="sans-serif"><b>Daniel Veillard <veillard@redhat.com></b></font>
<p><font size=1 face="sans-serif">20/11/2006 16:50</font>
<br><font size=1 face="sans-serif">Veuillez répondre à veillard</font>
<br>
<td><font size=1 face="Arial"> </font>
<br><font size=1 face="sans-serif"> Pour : michel.ponceau@bull.net</font>
<br><font size=1 face="sans-serif"> cc : libvir-list@redhat.com</font>
<br><font size=1 face="sans-serif"> Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain</font></table>
<br>
<br><font size=2 face="Courier New">On Thu, Nov 16, 2006 at 12:19:13PM -0500, Daniel Veillard wrote:<br>
> On Tue, Nov 14, 2006 at 10:05:47AM -0500, Daniel Veillard wrote:<br>
> > 5/ virDomainXMLDevID does direct acces to xs_directory() and xs_read(),<br>
> > that's not proper it should not call xenStore directly that need to<br>
> > be cleaned up, define one high level function exported from <br>
> > xs_internal.[ch] and call that but no direct access should be done<br>
> > that leads to unmaintainable code.<br>
> <br>
> That still need to be isolated, I added a TODO in src/xml.c to this effect.<br>
<br>
Okay I have done it, as a new function xenStoreDomainGetNetworkID() from<br>
xs_internal.[ch]<br>
Could you check out the version from CVS and verify I didn't added any<br>
regression ?<br>
<br>
thanks,<br>
<br>
Daniel<br>
<br>
-- <br>
Red Hat Virtualization group http://redhat.com/virtualization/<br>
Daniel Veillard | virtualization library http://libvirt.org/<br>
veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/<br>
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/<br>
</font>
<br>