Oops, forgot the list... ---------- Forwarded message ---------- From: Anton Protopopov <<a href="mailto:aspsk2@gmail.com">aspsk2@gmail.com</a>> Date: 21.02.2008 21:25 Subject: Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo To: <a href="mailto:veillard@redhat.com">veillard@redhat.com</a> I think, that if pnext = &vm; and *pnext = calloc(...); then vm = calloc(...); Isn't it? <div>2008/2/21, Daniel Veillard <<a href="mailto:veillard@redhat.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">veillard@redhat.com</a>>:<div> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On Thu, Feb 21, 2008 at 08:59:01PM +0300, Anton Protopopov wrote: > > Hi, > the patch is now in attachement.. > I think, that the statement > if (!vm) > vm = *pnext; > will never be executed: in the first pass, we have already check this > a few lines before; in next passes, vm remains the same... > Anton Hum, that doesn't match what I see. vm is initialized to NULL on entry and no changed before the loop, so on first iteration of the loop vm is set using that code. I don't understand the logic of your patch, Daniel -- Red Hat Virtualization group <a href="http://redhat.com/virtualization/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://redhat.com/virtualization/</a> Daniel Veillard | virtualization library <a href="http://libvirt.org/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://libvirt.org/</a> <a href="mailto:veillard@redhat.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">veillard@redhat.com</a> | libxml GNOME XML XSLT toolkit <a href="http://xmlsoft.org/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://xmlsoft.org/</a> <a href="http://veillard.com/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://veillard.com/</a> | Rpmfind RPM search engine <a href="http://rpmfind.net/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://rpmfind.net/</a> </blockquote></div></div>