<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1"> <META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.38"> <TITLE>RE: [libvirt] [PATCH] spec file enhancements for minimal "client-only" build</TITLE> </HEAD> <BODY>  I really only put in the removal of the devel sub-package for symmetry with the optional removal of the python sub-package. However - I don't really feel strongly one way or the other about that...so can redo this without the devel removal. It should be an easy fix...I'll have time to take a look at it a little later today. -----Original Message----- From: Daniel P. Berrange [<A HREF="mailto:berrange@redhat.com">mailto:berrange@redhat.com</A>] Sent: Tue 9/16/2008 6:38 AM To: Ben Guthro Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] spec file enhancements for minimal "client-only" build On Mon, Sep 15, 2008 at 02:55:40PM -0400, Ben Guthro wrote: > Attached is a patch to add some additional options to the spec file, > allowing for more flexibility when building. > With this patch, it allows you to build a "client-only" version of > libvirt for machines that may have an interest in communicating over the > remote driver, but do not have a hypervisor themselves. While in general I think this is useful, I don't see the point in the disabling of the -devel sub-RPM. This doesn't impact anything at compile time, and if you don't want it post-build, then simply don't distribute it. The -devel could still be useful for a client only version, if people want to build client apps. As it is the extra conditionals for disabling -devel just clutter the spec file more without any obvious advantage. I'd ACK something without the -devel conditionals. Daniel -- |: Red Hat, Engineering, London -o- <A HREF="http://people.redhat.com/berrange/">http://people.redhat.com/berrange/</A> :| |: <A HREF="http://libvirt.org">http://libvirt.org</A> -o- <A HREF="http://virt-manager.org">http://virt-manager.org</A> -o- <A HREF="http://ovirt.org">http://ovirt.org</A> :| |: <A HREF="http://autobuild.org">http://autobuild.org</A> -o- <A HREF="http://search.cpan.org/~danberr/">http://search.cpan.org/~danberr/</A> :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| </BODY> </HTML>