Hi Daniel, <br><br>Are you going to apply this to mainline?. Was just wondering if you have any other concerns so that i could work on those if at all there are other better ways you would have. <br><br>Thanks <br>--<br clear="all">
Harshavardhana<br>Gluster - <a href="http://www.gluster.com/">http://www.gluster.com/</a><br>
<br><br><div class="gmail_quote">On Sat, Jul 18, 2009 at 9:12 AM, Harshavardhana <span dir="ltr"><<a href="mailto:harsha@gluster.com">harsha@gluster.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Daniel,<br><br> Thanks for the pointers, i will keep this mind as and when the problem is fixed i will send a patch against those specific changes. <br><br>Regards<br><font color="#888888">--<br clear="all">Harshavardhana<br>
Z Research Inc <a href="http://www.zresearch.com/" target="_blank">http://www.zresearch.com/</a></font><div><div></div><div class="h5"><br>
<br><br><div class="gmail_quote">On Fri, Jul 17, 2009 at 11:58 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Thu, Jul 16, 2009 at 08:24:09PM +0530, Harshavardhana wrote:<br>
> Hi Daniel,<br>
><br>
> On Thu, Jul 16, 2009 at 7:46 PM, Daniel P. Berrange <<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>>wrote:<br>
><br>
> > On Thu, Jul 16, 2009 at 06:06:25AM -0700, Harshavardhana wrote:<br>
> > > New option index added to support -o options for various netfs.<br>
> > > Currently added an option for glusterfs.<br>
> ><br>
> > What effect does it have ? Or why do we want/need it<br>
> ><br>
><br>
> Options could be required for filesystem to have few enhaced handling at the<br>
> site where they will be under use. Correct approach for a configurable will<br>
> be a new "XML" option in this case.<br>
><br>
> Regarding current patch:<br>
> This is required for the glusterfs to work properly with VM's. Right now<br>
> there is a<br>
> problem/difficulty in using direct-io based mechanism in the fuse kernel<br>
> module<br>
> when used with "XEN" in its "tap:aio" framework, we have seen xen vms hang<br>
> over glusterfs or any fuse based filesystem due to fact that fuse module<br>
> doesn't yet support "aio" with O_DIRECT internally as a kernel module. To<br>
> have a work around fix we have to hardcode this value due to its usage in<br>
> case of VM's.<br>
><br>
> We are currently fixing this problem by fixing directly O_DIRECT problem in<br>
> fuse. Which will be available in later releases for kernel.<br>
<br>
</div>ACK, I see why you need this for the current releases of kernel/glusterfs.<br>
<br>
As & when this problem is fixed we'll need to either remove this, or<br>
provide a way to turn it off again. I don't think this is the kind of<br>
tunable that should be exposed in the XML, since this is really just a<br>
hack to work around a bug in a specific releases. Someone using libvirt<br>
has no way to decide whether the hack is needed or not, so making them<br>
set it in the XML would not be desirable. One possibility would be to<br>
have a config file /etc/libvirt/storage.conf for controlling certain<br>
options like this per host.<br>
<div><div></div><div><br>
Regards,<br>
Daniel<br>
--<br>
|: Red Hat, Engineering, London -o- <a href="http://people.redhat.com/berrange/" target="_blank">http://people.redhat.com/berrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> -o- <a href="http://ovirt.org" target="_blank">http://ovirt.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/%7Edanberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|<br>
<br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br>