<tt>"Daniel P. Berrange" <berrange@redhat.com> wrote on 03/18/2010 12:51:55 PM: </tt> <tt>> > Please respond to "Daniel P. Berrange"</tt> <tt>> > On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: > > On 03/18/2010 09:15 AM, Stefan Berger wrote: > > > This patch adds recursive locks necessary due to the processing of > > > network filter XML that can reference other network filters, including > > > references that cause looks. Loops in the XML are prevented but their > > > detection requires recursive locks. > > > > ACK. I had to double-check MSDN to make sure that threads-win32 already > > creates recursive mutex by default. > > I don't supposed you read if its possible to make it non-recursive, since > the orginal impl is supposed to be non-recursive ! > </tt> <tt>From what I remember from some msdn page is that the win32 mutexes are all recursive. So, the call that I made for creating a recursive mutex by calling the virMutexInit() function is not correct -- it should be the other way around... Something to fix some other day ?</tt> <tt> Stefan</tt> <tt> > Daniel > -- > |: Red Hat, Engineering, London -o- </tt><a href=http://people.redhat.com/berrange/:|><tt>http://people.redhat.com/berrange/:|</tt></a><tt> > |: </tt><a href=http://libvirt.org/><tt>http://libvirt.org</tt></a><tt> -o- </tt><a href="http://virt-manager.org/"><tt>http://virt-manager.org</tt></a><tt> -o- </tt><a href=http://deltacloud.org:|/><tt>http://deltacloud.org:|</tt></a><tt> > |: </tt><a href=http://autobuild.org/><tt>http://autobuild.org</tt></a><tt> -o- </tt><a href=http://search.cpan.org/~danberr/:|><tt>http://search.cpan.org/~danberr/:|</tt></a><tt> > |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| </tt>