<tt>"Daniel P. Berrange" <berrange@redhat.com> wrote on 03/25/2010 10:18:25 AM: > Please respond to "Daniel P. Berrange"</tt> <tt>> > On Thu, Mar 25, 2010 at 10:02:38AM -0400, Stefan Berger wrote: > > Due to these and other changes I would like to post a 'v4' patch series > > with an additional patch installing a couple of example filters. > > That's fine with me - BTW, i notice in the nwfilter_conf.c some of the > objects are called 'FilterPool' instead of just 'Filter' - is that > delibrate, or a cut +paste mistake from copying existing storage_conf.c > code.</tt> <tt>Some of that is (still) deliberate because from the perspective of the driver I</tt> <tt>regard the collection of filters as a pool and within that pool I can search</tt> <tt>for filters by for example UUID or name and that's where function names like</tt> <tt>virNWFilterPoolObjFindByUUID/ByName stem from. So, yes, it's derived from</tt> <tt>storage_conf.c but to me the naming of those functions still makes sense...</tt> <tt> Stefan</tt> <tt> > > > Daniel > -- > |: Red Hat, Engineering, London -o- </tt><a href=http://people.redhat.com/berrange/:|><tt>http://people.redhat.com/berrange/:|</tt></a><tt> > |: </tt><a href=http://libvirt.org/><tt>http://libvirt.org</tt></a><tt> -o- </tt><a href="http://virt-manager.org/"><tt>http://virt-manager.org</tt></a><tt> -o- </tt><a href=http://deltacloud.org:|/><tt>http://deltacloud.org:|</tt></a><tt> > |: </tt><a href=http://autobuild.org/><tt>http://autobuild.org</tt></a><tt> -o- </tt><a href=http://search.cpan.org/~danberr/:|><tt>http://search.cpan.org/~danberr/:|</tt></a><tt> > |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| </tt>