<br><tt><font size=2>libvir-list-bounces@redhat.com wrote on 03/30/2010
12:20:26 PM:<br>
<br>
> <br>
> ---<br>
>  src/conf/nwfilter_conf.c |   10 +++++-----<br>
>  1 files changed, 5 insertions(+), 5 deletions(-)<br>
> <br>
> diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c<br>
> index 668918d..24b79a7 100644<br>
> --- a/src/conf/nwfilter_conf.c<br>
> +++ b/src/conf/nwfilter_conf.c<br>
> @@ -1226,7 +1226,7 @@ virNWFilterRuleDetailsParse(virConnectPtr conn<br>
> ATTRIBUTE_UNUSED,<br>
>  <br>
>                    
     case DATATYPE_UINT8:<br>
>                    
         storage_ptr = &item->u.u8;<br>
> -                    
       if (sscanf(prop, "%d", &int_val)
== 1) {<br>
> +                    
       if (virStrToLong_i(prop, NULL, 10, <br>
> &int_val) >= 0) {<br>
>                    
             if (int_val >= 0 &&
int_val <= 0xff) {<br>
>                    
                 if (!validator)<br>
>                    
                     *(uint8_t
*)storage_ptr = int_val;<br>
> @@ -1240,7 +1240,7 @@ virNWFilterRuleDetailsParse(virConnectPtr conn<br>
> ATTRIBUTE_UNUSED,<br>
>  <br>
>                    
     case DATATYPE_UINT16:<br>
>                    
         storage_ptr = &item->u.u16;<br>
> -                    
       if (sscanf(prop, "%d", &int_val)
== 1) {<br>
> +                    
       if (virStrToLong_i(prop, NULL, 10, <br>
> &int_val) >= 0) {<br>
>                    
             if (int_val >= 0 &&
int_val <= 0xffff) {<br>
>                    
                 if (!validator)<br>
>                    
                     *(uint16_t
*)storage_ptr = int_val;<br>
> @@ -1264,7 +1264,7 @@ virNWFilterRuleDetailsParse(virConnectPtr conn<br>
> ATTRIBUTE_UNUSED,<br>
>                    
     case DATATYPE_IPMASK:<br>
>                    
         storage_ptr = &item->u.u8;<br>
>                    
         if (!virNWIPv4AddressParser(prop, &ipaddr))
{<br>
> -                    
           if (sscanf(prop, "%d",
&int_val) == 1) {<br>
> +                    
           if (virStrToLong_i(prop, NULL,
10, <br>
> &int_val) >= 0) {<br>
>                    
                 if (int_val
>= 0 && int_val <= 32) {<br>
>                    
                     if
(!validator)<br>
>                    
                     
   *(uint8_t *)storage_ptr =<br>
> @@ -1319,7 +1319,7 @@ virNWFilterRuleDetailsParse(virConnectPtr conn<br>
> ATTRIBUTE_UNUSED,<br>
>                    
     case DATATYPE_IPV6MASK:<br>
>                    
         storage_ptr = &item->u.u8;<br>
>                    
         if (!virNWIPv6AddressParser(prop, &ipaddr))
{<br>
> -                    
           if (sscanf(prop, "%d",
&int_val) == 1) {<br>
> +                    
           if (virStrToLong_i(prop, NULL,
10, <br>
> &int_val) >= 0) {<br>
>                    
                 if (int_val
>= 0 && int_val <= 128) {<br>
>                    
                     if
(!validator)<br>
>                    
                     
   *(uint8_t *)storage_ptr =<br>
> @@ -1607,7 +1607,7 @@ virNWFilterRuleParse(virConnectPtr conn,<br>
>      ret->priority = MAX_RULE_PRIORITY / 2;<br>
>  <br>
>      if (prio) {<br>
> -        if (sscanf(prio, "%d", (int
*)&priority) == 1) {<br>
> +        if (virStrToLong_i(prio, NULL, 10, (int
*)&priority) >= 0) {<br>
>              if ((int)priority
>= 0 && priority <= MAX_RULE_PRIORITY)<br>
>                  ret->priority
= priority;<br>
>          }<br>
> -- </font></tt>
<br>
<br><tt><font size=2>Looks good to me.</font></tt>
<br>
<br>
<br><tt><font size=2>   Stefan</font></tt>
<br>
<br><tt><font size=2><br>
> 1.6.3.3<br>
> <br>
> --<br>
> libvir-list mailing list<br>
> libvir-list@redhat.com<br>
> </font></tt><a href="https://www.redhat.com/mailman/listinfo/libvir-list"><tt><font size=2>https://www.redhat.com/mailman/listinfo/libvir-list</font></tt></a><tt><font size=2><br>
</font></tt>