<tt>Eric Blake <eblake@redhat.com> wrote on 04/07/2010 05:15:12 PM: </tt> <tt>> > On 04/07/2010 03:02 PM, Stefan Berger wrote: > >> If this is a bash test, you need to update the #!. > >> Otherwise, you have to give up on local variables. > > > > I'll change this to be a bash script. No point in making the test program > > portable across shells. > > > >>> + tmpfile=`mktemp` > >>> + tmpfile2=`mktemp` > >> > >> Not all systems have mktemp; is it worth adding fallback code in that > > case? > > > > Hm, two hardcoded files like '/tmp/nwfiltervmtest1' and > > '/tmp/nwfiltervmtest2' could actually be a replacement, no? > > Yeah, but names that obvious are prone to DoS attacks. If you are > assuming bash, you can at least use $RANDOM to get past the worst of the > security hole in being that blatant. Or, as long as we are assuming > bash and linux, you could just skip the test if mktemp doesn't exist.</tt> <tt>Alright, alright. I'll write a function that simulates mktemp if not available using the ${RANDOM} suffix.</tt> <tt>Though I hope nobody will DoS attack this test suite program :-)</tt> <tt> > > >> My review stops here - shell is my area of expertise, but my Linux > >> network filtering knowledge is sparse. > > > > Ok. Thanks for the review. Will adapt and re-post. > > Well, one of the joys of open source is that you can have multiple > reviewers, each with different angles of expertise, with a cumulative > review better than any one person could give.</tt> <tt>Yeah, definitely a good thing.</tt> <tt> Stefan</tt> <tt> > > -- > Eric Blake eblake@redhat.com +1-801-349-2682 > Libvirt virtualization library </tt><a href=http://libvirt.org/><tt>http://libvirt.org</tt></a><tt> > > [attachment "signature.asc" deleted by Stefan Berger/Watson/IBM] </tt>