<tt>Daniel Veillard <veillard@redhat.com> wrote on 04/08/2010 03:54:07 AM: </tt> <tt>> > Please respond to veillard</tt> <tt>> > On Wed, Apr 07, 2010 at 05:34:50PM -0400, Stefan Berger wrote: > > This patch adds new test cases to the existing nwfilter test program and > > adds a test script that must be run while a VM is running. This test > > script verifies that input network filter XML creates expected > > user-defined tables and rules on ebtables, iptables & ip6tables layer > > and verifies their content against expected content. The idea is that > > these tools always return exactly the same output when displaying the > > content of a user-defined table so that the diff tool can be used for > > simple text comparison. All supported protocols have at least one test > > case. > > This test program is not run automatically since it requires a running > > VM. > > I'm wondering a bit about this. > > So far all our embedded tests from "make tests" are supposed to be > agnostic on the machine state, and I wonder if it ain't preferable to > kepp them that way. For example we have no real save/restore or > migration tests here because like the nwfilter rukes testing that would > require actual VM runnings. > To me it seems this test should rather be targetted to the TCK, the > separate test suite for libvirt: > > </tt><a href="http://libvirt.org/git/?p=libvirt-tck.git"><tt>http://libvirt.org/git/?p=libvirt-tck.git</tt></a><tt> > > that's really the place where tests relying on actual system behaviour > should be implemented, and IMHO the more people start to look at it the > better. > Dan sent an introduction when he created the project > </tt><a href="http://www.mail-archive.com/libvir-list@redhat.com/msg12703.html"><tt>http://www.mail-archive.com/libvir-list@redhat.com/msg12703.html</tt></a><tt> > > and an update recently: > </tt><a href="http://www.mail-archive.com/libvir-list@redhat.com/msg21503.html"><tt>http://www.mail-archive.com/libvir-list@redhat.com/msg21503.html</tt></a><tt> > > so some of the hairy shell scripting for this test could be replaced > with (less hairy ?) Perl testing, but in a framework really intended > to have actual running domains. > > I understand that the current version of the test is not supposed to > run if there is no domain target, but really it break the rule that > libvirt "make tests" should not be dependant on the machine state,</tt> <tt>Ok, I'll adapt it for the TCK project.</tt> <tt> Stefan</tt> <tt> > > Daniel > > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit </tt><a href=http://xmlsoft.org/><tt>http://xmlsoft.org/</tt></a><tt> > daniel@veillard.com | Rpmfind RPM search engine </tt><a href=http://rpmfind.net/><tt>http://rpmfind.net/</tt></a><tt> > </tt><a href=http://veillard.com/><tt>http://veillard.com/</tt></a><tt> | virtualization library </tt><a href=http://libvirt.org/><tt>http://libvirt.org/</tt></a><tt> </tt>