<br><tt><font size=2>libvir-list-bounces@redhat.com wrote on 04/19/2010
09:18:15 AM:<br>
<br>
> <br>
> * src/nwfilter/nwfilter_driver.c: Fix locking & NULL checks<br>
> in nwfilterDriverActive()<br>
> ---<br>
> src/nwfilter/nwfilter_driver.c | 11 +++++++++--<br>
> 1 files changed, 9 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c<br>
> index 58df4e1..412c5b8 100644<br>
> --- a/src/nwfilter/nwfilter_driver.c<br>
> +++ b/src/nwfilter/nwfilter_driver.c<br>
> @@ -153,9 +153,16 @@ nwfilterDriverReload(void) {<br>
> */<br>
> static int<br>
> nwfilterDriverActive(void) {<br>
> - if (!driverState->pools.count)<br>
> + int ret;<br>
> +<br>
> + if (!driverState)<br>
> return 0;<br>
> - return 1;<br>
> +<br>
> + nwfilterDriverLock(driverState);<br>
> + ret = driverState->pools.count ? 1 : 0;<br>
> + nwfilterDriverUnlock(driverState);<br>
> +<br>
> + return ret;<br>
> }<br>
> </font></tt>
<br>
<br><tt><font size=2>ACK.</font></tt>
<br>
<br><tt><font size=2> Stefan</font></tt>
<br>