<br><tt><font size=2>Daniel Veillard <veillard@redhat.com> wrote
on 04/22/2010 07:41:47 AM:<br>
<br>
<br>
> <br>
> [...]<br>
> > <br>
> > + if (virNWFilterLockIface(req->ifname))<br>
> > + goto err_no_lock;<br>
> > +<br>
> <br>
> As long as the error is caught when used, and properly
propagated<br>
> that strategy is correct IMHO.<br>
> <br>
> otherwise, patch looks okay to me,<br>
> <br>
> ACK once those forever loops are replaced with error returns.</font></tt>
<br>
<br><tt><font size=2>I fixed this and pushed it. I had to also remove an
ifaceDown() call and precede another one with ifaceCheck().</font></tt>
<br>
<br><tt><font size=2> Stefan</font></tt>
<br><tt><font size=2><br>
> <br>
> Daniel<br>
> <br>
> -- <br>
> Daniel Veillard | libxml Gnome XML XSLT toolkit
</font></tt><a href=http://xmlsoft.org/><tt><font size=2>http://xmlsoft.org/</font></tt></a><tt><font size=2><br>
> daniel@veillard.com | Rpmfind RPM search engine </font></tt><a href=http://rpmfind.net/><tt><font size=2>http://rpmfind.net/</font></tt></a><tt><font size=2><br>
> </font></tt><a href=http://veillard.com/><tt><font size=2>http://veillard.com/</font></tt></a><tt><font size=2>
| virtualization library </font></tt><a href=http://libvirt.org/><tt><font size=2>http://libvirt.org/</font></tt></a><tt><font size=2><br>
</font></tt>