<br><tt><font size=2>libvir-list-bounces@redhat.com wrote on 08/18/2010
07:45:05 PM:<br>
<br>
<br>
> libvir-list-bounces@redhat.com</font></tt>
<br><tt><font size=2>> <br>
> * src/nwfilter/nwfilter_driver.c (nwfilterLog): Delete.<br>
> (nwfilterDriverStartup): Use virReportOOMError instead.<br>
> ---<br>
> <br>
> No point making printf uses harder to audit by hiding them in a macro,<br>
> especially when this file already uses virReportOOMError elsewhere.<br>
> <br>
>  src/nwfilter/nwfilter_driver.c |    6 +-----<br>
>  1 files changed, 1 insertions(+), 5 deletions(-)<br>
> <br>
> diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c<br>
> index 0e8241e..bda50f9 100644<br>
> --- a/src/nwfilter/nwfilter_driver.c<br>
> +++ b/src/nwfilter/nwfilter_driver.c<br>
> @@ -42,9 +42,6 @@<br>
> <br>
>  #define VIR_FROM_THIS VIR_FROM_NWFILTER<br>
> <br>
> -#define nwfilterLog(msg...) fprintf(stderr, msg)<br>
> -<br>
> -<br>
>  static virNWFilterDriverStatePtr driverState;<br>
> <br>
>  static int nwfilterDriverShutdown(void);<br>
> @@ -95,7 +92,6 @@ nwfilterDriverStartup(int privileged) {<br>
>              goto error;<br>
> <br>
>          if (virAsprintf(&base, "%s/.libvirt",
userdir) == -1) {<br>
> -            nwfilterLog("out of
memory in virAsprintf");<br>
>              VIR_FREE(userdir);<br>
>              goto out_of_memory;<br>
>          }<br>
> @@ -118,7 +114,7 @@ nwfilterDriverStartup(int privileged) {<br>
>      return 0;<br>
> <br>
>  out_of_memory:<br>
> -    nwfilterLog("virNWFilterStartup: out of memory");<br>
> +    virReportOOMError();<br>
> <br>
>  error:<br>
>      VIR_FREE(base);</font></tt>
<br>
<br><tt><font size=2>ACK.</font></tt>
<br>
<br><tt><font size=2>  Stefan</font></tt>
<br>