<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 06/21/2011 01:16 PM, Eric Blake wrote:
<blockquote cite="mid:4E00D1E4.6040205@redhat.com" type="cite">
<pre wrap="">On 06/21/2011 06:01 AM, Gerhard Stenzel wrote:
</pre>
<blockquote type="cite">
<pre wrap="">+ rc = ifaceGetMacaddr(linkdev, oldmac);
+
+ if (rc) {
+ virReportSystemError(rc,
</pre>
</blockquote>
<pre wrap="">
Sorry for not catching this sooner. This should probably be
virReportSystemError(errno,...), assuming that ifaceGetMacaddr
guarantees a sane errno setting (at any rate, you used errno for
ifaceSetMacaddr later on).
</pre>
</blockquote>
It should be ok the way it is since ifaceGetMacAddr() returns either
EINVAL or the content of errno.<br>
<br>
Stefan<br>
<blockquote cite="mid:4E00D1E4.6040205@redhat.com" type="cite">
<pre wrap=""></pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
--
libvir-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre>
</blockquote>
<br>
</body>
</html>