<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>On Nov 28, 2011, at 11:23 AM, Eric Blake wrote:</div><div><div><br class="Apple-interchange-newline"><blockquote type="cite"><div>s/xbox/vbox/ in the subject<br><br></div></blockquote><div><br></div><div><div>Whoops... Hope I didn't disappoint anybody hoping for libvirt support on the xbox. </div><div><br></div></div><blockquote type="cite"><div>On 11/28/2011 07:26 AM, Lorin Hochstein wrote:<br><blockquote type="cite">virt-xml-validate fails when run on a domain XML file of type 'vbox'. <br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">For failing test case, see <a href="https://bugzilla.redhat.com/show_bug.cgi?id=757097">https://bugzilla.redhat.com/show_bug.cgi?id=757097</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">This patch updates the XML schema so it accepts type 'vbox'.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">---<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng<br></blockquote><blockquote type="cite">index 8968ee6..444592c 100644<br></blockquote><blockquote type="cite">--- a/docs/schemas/domaincommon.rng<br></blockquote><blockquote type="cite">+++ b/docs/schemas/domaincommon.rng<br></blockquote><blockquote type="cite">@@ -85,6 +85,7 @@<br></blockquote><blockquote type="cite"> <value>qemu</value><br></blockquote><blockquote type="cite"> <value>lxc</value><br></blockquote><blockquote type="cite"> <value>openvz</value><br></blockquote><blockquote type="cite">+ <value>vbox</value><br></blockquote><blockquote type="cite"> <value>test</value><br></blockquote><br>ACK that we had a problem. Actually, it was more than just vbox<br>missing. virDomainVirtTypeToString in domain_conf.c has the full list;<br>on the other hand, that list had elements that aren't in use by any<br>existing hypervisor driver.<br><br>Here's what I'm squashing into your patch before pushing. I also added<br>you to AUTHORS; let me know if I need to update any preferred spelling.<br><br></div></blockquote><div><br></div><div>Patch looks good to me (including AUTHORS spelling).</div><div><br></div><div><div>Lorin</div><div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Lorin Hochstein, Computer Scientist</div><div>USC Information Sciences Institute</div><div>703.812.3710</div><div><a href="http://www.east.isi.edu/~lorin">http://www.east.isi.edu/~lorin</a></div><div><br></div></div></span></span></div></div></div></div></div></body></html>