<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 23, 2012, at 7:21 PM, Laine Stump wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><br>Related to this patch - while looking at the uses of<br>virNetDevVPortProfileAssociate(), I found the function<br>qemuMigrationVPAssociatePortProfiles() in src/qemu/qemu_migration.c. It<br>calls virNetDevVPortProfileAssociate() without ever calling<br>virNetDevMacVLanVPortProfileRegisterCallback(). I'm wondering if either<br>1) the normal setup of port profiles (is<br>virNetDevMacVLanCreateWithVPortProfile) is missed during migration, and<br>this function needs to be changed/enhanced, or 2) this associate is<br>redundant. I don't have the hardware to test either a migration *or*<br>vepa mode, but this seems like something important to determine (and fix<br>if it's broken).<br></span></blockquote></div><br><div>I'm currently looking at migration, and I will follow this up ASAP, because</div><div>of the complication of having to go through pre-association there are 2 calls</div><div>to virNetDevVPortProfileAssociate() and only when migration has completed</div><div>successfully the callback should be registered.</div><div><br></div><div>The combined patches check out ok, but I haven't covered all tests yet.</div><div><br></div><div>DirkH</div></body></html>