Sorry for misunderstood the code ,test and submit the patch mistakenly, will submit a new one. <div class="gmail_quote">2012/6/8 Daniel P. Berrange <<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Jun 05, 2012 at 02:21:10PM +0800, Royce Lv wrote: </div><div><div class="h5">> Libvirt-socket-rw and libvirt-socket-ro are not used only for libvirt or > root user, > but also for unprivileged application such as vdsm, > Restrain the rundir only read/search for libvirt prevent comunication > with unprivileged client,change rundir the permission equals to the sockets > permission. > See bug: > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=828073" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=828073</a> > > Signed-off-by: lvroyce <<a href="mailto:lvroyce@linux.vnet.ibm.com">lvroyce@linux.vnet.ibm.com</a>> > --- > daemon/libvirtd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c > index c74cd43..6095072 100644 > --- a/daemon/libvirtd.c > +++ b/daemon/libvirtd.c > @@ -293,7 +293,7 @@ daemonUnixSocketPaths(struct daemonConfig *config, > if (!(rundir = virGetUserRuntimeDirectory())) > goto error; > > - old_umask = umask(077); > + old_umask = umask(022); > if (virFileMakePath(rundir) < 0) { > umask(old_umask); > goto error; </div></div>The bug you quote above talks about being unable to connect to /var/run/libvirt/libvirt-sock for the privileged libvirtd. The change you are proposing here only touches unprivileged libvirtd when it creates $XDG_RUNTIME_DIR/libvirt. Furthermore the change you are proposing is a security flaw, since the $XDG_RUNTIME_DIR/libvirt directory is *only* intended to be accessed by the current unprivileged user. Using a umask of 022 lets it be accessible to any user. So NACK to this Daniel -- |: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :| |: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :| |: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/%7Edanberr/" target="_blank">http://search.cpan.org/~danberr/</a> :| |: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :| </blockquote></div>