<div dir="ltr"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 21, 2012 at 10:21 AM, Li Zhang <span dir="ltr"><<a href="mailto:zhlcindy@gmail.com" target="_blank">zhlcindy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><div>On Thu, Dec 20, 2012 at 6:28 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>On Thu, Dec 20, 2012 at 02:02:23PM +0800, Li Zhang wrote:<br>
> From: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com" target="_blank">zhlcindy@linux.vnet.ibm.com</a>><br>
><br>
> On PPC64 platform, it sets USB option in -machine option. It is<br>
> set as the following:<br>
> -machine pseries,usb=off<br>
><br>
> This will disable USB, which avoids creating one USB controller<br>
> implicitly in the platform's initialization. Libvirt will add one<br>
> USB controller if there is no definition in XML file. Users also can<br>
> add one specific USB controller in the XML file as the following:<br>
><br>
> <controller type='usb' index='0' model='pci-ohci'><br>
> </controller><br>
<br>
</div>NACK, current behaviour matches libvirt on x86, where we also<br>
add a USB controller by default.<br></blockquote><div><br></div></div><div>Yes, I saw the code in Libvirt which adds a USB controller by default.<br></div><div><br>My problem is that: <br></div><div>In QEMU for pseries, default VGA is enabled, one USB controller is created and USB keyboard and mouse are created.<br>
</div><div>If libvirt also creates USB controller with -device xxxx, it will produce the error:<br><br>qemu-system-ppc64: -device pci-ohci,id=usb,bus=pci,addr=0x1.0x2: PCI: single function device can't be populated in function 1.2<br>
qemu-system-ppc64: -device pci-ohci,id=usb,bus=pci,addr=0x1.0x2: Device 'pci-ohci' could not be initialized<br>2012-12-20 15:16:54.985+0000: shutting down<br><br></div><div>To avoid the conflict, we need to use -machine name,usb=off to disable USB option.<br>
</div><div>My patch doesn't create the default USB controller, it only help disable USB option.<br><br></div></div></div></div></div></blockquote><div><br></div><div>Hi Daniel,<br><br></div><div>I think this is one bug for USB option. <br>
USB option in machine options can't be used with -device xxxx at the same time<br></div><div>Actually, some platforms would like to enable USB option by default.<br></div><div>So we need to pass usb=off, then use -device xxx to create a USB controller in libvirt.<br>
</div><div>We discussed this problem in QEMU mailing list before.<br>Here is the link,<br><a href="http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg01008.html">http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg01008.html</a><br>
</div><div><br>Any idea?<br><br>Thanks. :)<br> </div><div><br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div>Thanks. :)<br></div><div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
The mechanism for disabling the default USB controlle ris<br>
to use<br>
<br>
<controller type='usb' index='0' model='none'><br>
<br>
PPC should follow this same behaviour<br>
<span><font color="#888888"><br>
<br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
</font></span></blockquote></div></div><span><font color="#888888"><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</font></span></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</div></div>