<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 21, 2012 at 10:27 AM, Li Zhang <span dir="ltr"><<a href="mailto:zhlcindy@gmail.com" target="_blank">zhlcindy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Thu, Dec 20, 2012 at 6:31 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>On Thu, Dec 20, 2012 at 02:02:26PM +0800, Li Zhang wrote:<br>
> From: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com" target="_blank">zhlcindy@linux.vnet.ibm.com</a>><br>
><br>
> pseries machine type is preferred for ppc64.<br>
> This patch is to set pseries as the default machine type.<br>
><br>
> Signed-off-by: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com" target="_blank">zhlcindy@linux.vnet.ibm.com</a>><br>
> ---<br>
> src/conf/capabilities.c | 6 ++++++<br>
> 1 file changed, 6 insertions(+)<br>
><br>
> diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c<br>
> index 7cdb5b7..ba03a84 100644<br>
> --- a/src/conf/capabilities.c<br>
> +++ b/src/conf/capabilities.c<br>
> @@ -624,6 +624,12 @@ virCapabilitiesDefaultGuestMachine(virCapsPtr caps,<br>
> guest-><a href="http://arch.id" target="_blank">arch.id</a> != arch)<br>
> continue;<br>
><br>
> + for (j = 0; j < guest->arch.defaultInfo.nmachines; j ++) {<br>
> + if (arch == VIR_ARCH_PPC64 &&<br>
> + STREQ(guest->arch.defaultInfo.machines[j]->name, "pseries"))<br>
> + return guest->arch.defaultInfo.machines[j]->name;<br>
> + }<br>
> +<br>
> for (j = 0; j < guest->arch.ndomains; j++) {<br>
> virCapsGuestDomainPtr dom = guest->arch.domains[j];<br>
><br>
<br>
</div></div>NACK, libvirt queries QEMU to determine the default machine type:<br>
<br>
$ qemu-system-ppc64 -M '?'<br>
Supported machines are:<br>
none empty machine<br>
ref405ep ref405ep<br>
taihu taihu<br>
bamboo bamboo<br>
mac99 Mac99 based PowerMAC (default)<br>
^^^^^^^^^<br>
g3beige Heathrow based PowerMAC<br>
prep PowerPC PREP platform<br>
pseries pSeries Logical Partition (PAPR compliant)<br>
virtex-ml507 Xilinx Virtex ML507 reference design<br>
ppce500 generic paravirt e500 platform<br>
mpc8544ds mpc8544ds<br>
<br>
<br>
So if you want to change the default, then you should modify QEMU<br>
upstream<br></blockquote><div><br></div></div></div><div>Actually, Libvirt has redefined the default machine in the function virCapabilitiesDefaultGuestMachine.<br></div><div>The default machine will be the last one, mpc8544ds which is not we expect.<br>
<br></div></div></div></div></blockquote><div><br></div><div>Please ignore my above comment. Upstream is still mac99.<br></div><div>My concern is that it may be a little hard to change it in QEMU. <br></div><div> <br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div>Thanks.<br></div><div class="im"><div>
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span><font color="#888888"><br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
</font></span></blockquote></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</div></div>