<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <html><head><title>Coverity error reader: /home/jferlan/libvirt.cov.curr/src/esx/esx_driver.c</title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head> <body link="#000000" vlink="#000000"><pre> <a name="line891">891 </a> /* <a name="line892">892 </a> * URI format: {vpx|esx|gsx}://[<username>@]<hostname>[:<port>]/[<path>][?<query parameter>...] <a name="line893">893 </a> * <path> = [<folder>/...]<datacenter>/[<folder>/...]<computeresource>[/<hostsystem>] <a name="line894">894 </a> * <a name="line895">895 </a> * If no port is specified the default port is set dependent on the scheme and <a name="line896">896 </a> * transport parameter: <a name="line897">897 </a> * - vpx+http 80 <a name="line898">898 </a> * - vpx+https 443 <a name="line899">899 </a> * - esx+http 80 <a name="line900">900 </a> * - esx+https 443 <a name="line901">901 </a> * - gsx+http 8222 <a name="line902">902 </a> * - gsx+https 8333 <a name="line903">903 </a> * <a name="line904">904 </a> * For a vpx:// connection <path> references a host managed by the vCenter. <a name="line905">905 </a> * In case the host is part of a cluster then <computeresource> is the cluster <a name="line906">906 </a> * name. Otherwise <computeresource> and <hostsystem> are equal and the later <a name="line907">907 </a> * can be omitted. As datacenters and computeresources can be organized in <a name="line908">908 </a> * folders those have to be included in <path>. <a name="line909">909 </a> * <a name="line910">910 </a> * Optional query parameters: <a name="line911">911 </a> * - transport={http|https} <a name="line912">912 </a> * - vcenter={<vcenter>|*} only useful for an esx:// connection <a name="line913">913 </a> * - no_verify={0|1} <a name="line914">914 </a> * - auto_answer={0|1} <a name="line915">915 </a> * - proxy=[{http|socks|socks4|socks4a|socks5}://]<hostname>[:<port>] <a name="line916">916 </a> * <a name="line917">917 </a> * If no transport parameter is specified https is used. <a name="line918">918 </a> * <a name="line919">919 </a> * The vcenter parameter is only necessary for migration, because the vCenter <a name="line920">920 </a> * server is in charge to initiate a migration between two ESX hosts. The <a name="line921">921 </a> * vcenter parameter can be set to an explicitly hostname or to *. If set to *, <a name="line922">922 </a> * the driver will check if the ESX host is managed by a vCenter and connect to <a name="line923">923 </a> * it. If the ESX host is not managed by a vCenter an error is reported. <a name="line924">924 </a> * <a name="line925">925 </a> * If the no_verify parameter is set to 1, this disables libcurl client checks <a name="line926">926 </a> * of the server's certificate. The default value it 0. <a name="line927">927 </a> * <a name="line928">928 </a> * If the auto_answer parameter is set to 1, the driver will respond to all <a name="line929">929 </a> * virtual machine questions with the default answer, otherwise virtual machine <a name="line930">930 </a> * questions will be reported as errors. The default value it 0. <a name="line931">931 </a> * <a name="line932">932 </a> * The proxy parameter allows to specify a proxy for to be used by libcurl. <a name="line933">933 </a> * The default for the optional <type> part is http and socks is synonymous for <a name="line934">934 </a> * socks5. The optional <port> part allows to override the default port 1080. <a name="line935">935 </a> */ <a name="line936">936 </a> static virDrvOpenStatus <a name="line937">937 </a> esxOpen(virConnectPtr conn, virConnectAuthPtr auth, <a name="line938">938 </a> unsigned int flags) <a name="line939">939 </a> { <a name="line940">940 </a> virDrvOpenStatus result = VIR_DRV_OPEN_ERROR; <a name="line941">941 </a> char *plus; <a name="line942">942 </a> esxPrivate *priv = NULL; <a name="line943">943 </a> char *potentialVCenterIpAddress = NULL; <a name="line944">944 </a> char vCenterIpAddress[NI_MAXHOST] = ""; <a name="line945">945 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:0"></a> (1) Event cond_false: </td> <td>Condition "__unsuppflags", taking false branch</td> </tr> <tr><td> <a name="error:1"></a> (2) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line946">946 </a> virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); <a name="line947">947 </a> <a name="line948">948 </a> /* Decline if the URI is NULL or the scheme is NULL */ </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:2"></a> (3) Event cond_false: </td> <td>Condition "conn->uri == NULL", taking false branch</td> </tr> <tr><td> <a name="error:3"></a> (4) Event cond_false: </td> <td>Condition "conn->uri->scheme == NULL", taking false branch</td> </tr> </table> <pre><a name="line949">949 </a> if (conn->uri == NULL || conn->uri->scheme == NULL) { <a name="line950">950 </a> return VIR_DRV_OPEN_DECLINED; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:4"></a> (5) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line951">951 </a> } <a name="line952">952 </a> <a name="line953">953 </a> /* Decline if the scheme is not one of {vpx|esx|gsx} */ <a name="line954">954 </a> plus = strchr(conn->uri->scheme, '+'); <a name="line955">955 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:5"></a> (6) Event cond_true: </td> <td>Condition "plus == NULL", taking true branch</td> </tr> </table> <pre><a name="line956">956 </a> if (plus == NULL) { </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:6"></a> (7) Event cond_false: </td> <td>Condition "c_strcasecmp(conn->uri->scheme, "vpx") != 0", taking false branch</td> </tr> </table> <pre><a name="line957">957 </a> if (STRCASENEQ(conn->uri->scheme, "vpx") && <a name="line958">958 </a> STRCASENEQ(conn->uri->scheme, "esx") && <a name="line959">959 </a> STRCASENEQ(conn->uri->scheme, "gsx")) { <a name="line960">960 </a> return VIR_DRV_OPEN_DECLINED; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:7"></a> (8) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line961">961 </a> } </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:8"></a> (9) Event if_fallthrough: </td> <td>Falling through to end of if statement</td> </tr> </table> <pre><a name="line962">962 </a> } else { <a name="line963">963 </a> if (plus - conn->uri->scheme != 3 || <a name="line964">964 </a> (STRCASENEQLEN(conn->uri->scheme, "vpx", 3) && <a name="line965">965 </a> STRCASENEQLEN(conn->uri->scheme, "esx", 3) && <a name="line966">966 </a> STRCASENEQLEN(conn->uri->scheme, "gsx", 3))) { <a name="line967">967 </a> return VIR_DRV_OPEN_DECLINED; <a name="line968">968 </a> } <a name="line969">969 </a> <a name="line970">970 </a> virReportError(VIR_ERR_INVALID_ARG, <a name="line971">971 </a> _("Transport '%s' in URI scheme is not supported, try again " <a name="line972">972 </a> "without the transport part"), plus + 1); <a name="line973">973 </a> return VIR_DRV_OPEN_ERROR; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:9"></a> (10) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line974">974 </a> } <a name="line975">975 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:10"></a> (11) Event cond_false: </td> <td>Condition "c_strcasecmp(conn->uri->scheme, "vpx") != 0", taking false branch</td> </tr> </table> <pre><a name="line976">976 </a> if (STRCASENEQ(conn->uri->scheme, "vpx") && <a name="line977">977 </a> conn->uri->path != NULL && STRNEQ(conn->uri->path, "/")) { <a name="line978">978 </a> VIR_WARN("Ignoring unexpected path '%s' for non-vpx scheme '%s'", <a name="line979">979 </a> conn->uri->path, conn->uri->scheme); </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:11"></a> (12) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line980">980 </a> } <a name="line981">981 </a> <a name="line982">982 </a> /* Require server part */ </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:12"></a> (13) Event cond_false: </td> <td>Condition "conn->uri->server == NULL", taking false branch</td> </tr> </table> <pre><a name="line983">983 </a> if (conn->uri->server == NULL) { <a name="line984">984 </a> virReportError(VIR_ERR_INVALID_ARG, "%s", <a name="line985">985 </a> _("URI is missing the server part")); <a name="line986">986 </a> return VIR_DRV_OPEN_ERROR; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:13"></a> (14) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line987">987 </a> } <a name="line988">988 </a> <a name="line989">989 </a> /* Require auth */ </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:14"></a> (15) Event cond_false: </td> <td>Condition "auth == NULL", taking false branch</td> </tr> <tr><td> <a name="error:15"></a> (16) Event cond_false: </td> <td>Condition "auth->cb == NULL", taking false branch</td> </tr> </table> <pre><a name="line990">990 </a> if (auth == NULL || auth->cb == NULL) { <a name="line991">991 </a> virReportError(VIR_ERR_INVALID_ARG, "%s", <a name="line992">992 </a> _("Missing or invalid auth pointer")); <a name="line993">993 </a> return VIR_DRV_OPEN_ERROR; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:16"></a> (17) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line994">994 </a> } <a name="line995">995 </a> <a name="line996">996 </a> /* Allocate per-connection private data */ </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:17"></a> (18) Event alloc_arg: </td> <td>"virAlloc(void *, size_t)" allocates memory that is stored into "priv". [<a href="164viralloc.c.html#model:virAlloc:a602cc7eca89056311937cf01d67144f">details</a>]</td> </tr> <tr><td> <a name="error:18"></a> (19) Event cond_false: </td> <td>Condition "virAlloc(&priv, 56UL /* sizeof (*priv) */) < 0", taking false branch</td> </tr> <tr><td>Also see events: </td> <td>[<a href="#error:24">leaked_storage</a>]</td></tr> </table> <pre><a name="line997">997 </a> if (VIR_ALLOC(priv) < 0) { <a name="line998">998 </a> virReportOOMError(); <a name="line999">999 </a> goto cleanup; </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:19"></a> (20) Event if_end: </td> <td>End of if statement</td> </tr> </table> <pre><a name="line1000">1000 </a> } <a name="line1001">1001 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:20"></a> (21) Event cond_true: </td> <td>Condition "esxUtil_ParseUri(&priv->parsedUri, conn->uri) < 0", taking true branch</td> </tr> </table> <pre><a name="line1002">1002 </a> if (esxUtil_ParseUri(&priv->parsedUri, conn->uri) < 0) { </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:21"></a> (22) Event goto: </td> <td>Jumping to label "cleanup"</td> </tr> </table> <pre><a name="line1003">1003 </a> goto cleanup; <a name="line1004">1004 </a> } <a name="line1005">1005 </a> <a name="line1006">1006 </a> priv->maxVcpus = -1; <a name="line1007">1007 </a> priv->supportsVMotion = esxVI_Boolean_Undefined; <a name="line1008">1008 </a> priv->supportsLongMode = esxVI_Boolean_Undefined; <a name="line1009">1009 </a> priv->usedCpuTimeCounterId = -1; <a name="line1010">1010 </a> <a name="line1011">1011 </a> /* <a name="line1012">1012 </a> * Set the port dependent on the transport protocol if no port is <a name="line1013">1013 </a> * specified. This allows us to rely on the port parameter being <a name="line1014">1014 </a> * correctly set when building URIs later on, without the need to <a name="line1015">1015 </a> * distinguish between the situations port == 0 and port != 0 <a name="line1016">1016 </a> */ <a name="line1017">1017 </a> if (conn->uri->port == 0) { <a name="line1018">1018 </a> if (STRCASEEQ(conn->uri->scheme, "vpx") || <a name="line1019">1019 </a> STRCASEEQ(conn->uri->scheme, "esx")) { <a name="line1020">1020 </a> if (STRCASEEQ(priv->parsedUri->transport, "https")) { <a name="line1021">1021 </a> conn->uri->port = 443; <a name="line1022">1022 </a> } else { <a name="line1023">1023 </a> conn->uri->port = 80; <a name="line1024">1024 </a> } <a name="line1025">1025 </a> } else { /* GSX */ <a name="line1026">1026 </a> if (STRCASEEQ(priv->parsedUri->transport, "https")) { <a name="line1027">1027 </a> conn->uri->port = 8333; <a name="line1028">1028 </a> } else { <a name="line1029">1029 </a> conn->uri->port = 8222; <a name="line1030">1030 </a> } <a name="line1031">1031 </a> } <a name="line1032">1032 </a> } <a name="line1033">1033 </a> <a name="line1034">1034 </a> if (STRCASEEQ(conn->uri->scheme, "esx") || <a name="line1035">1035 </a> STRCASEEQ(conn->uri->scheme, "gsx")) { <a name="line1036">1036 </a> /* Connect to host */ <a name="line1037">1037 </a> if (esxConnectToHost(priv, conn, auth, <a name="line1038">1038 </a> &potentialVCenterIpAddress) < 0) { <a name="line1039">1039 </a> goto cleanup; <a name="line1040">1040 </a> } <a name="line1041">1041 </a> <a name="line1042">1042 </a> /* Connect to vCenter */ <a name="line1043">1043 </a> if (priv->parsedUri->vCenter != NULL) { <a name="line1044">1044 </a> if (STREQ(priv->parsedUri->vCenter, "*")) { <a name="line1045">1045 </a> if (potentialVCenterIpAddress == NULL) { <a name="line1046">1046 </a> virReportError(VIR_ERR_INTERNAL_ERROR, "%s", <a name="line1047">1047 </a> _("This host is not managed by a vCenter")); <a name="line1048">1048 </a> goto cleanup; <a name="line1049">1049 </a> } <a name="line1050">1050 </a> <a name="line1051">1051 </a> if (virStrcpyStatic(vCenterIpAddress, <a name="line1052">1052 </a> potentialVCenterIpAddress) == NULL) { <a name="line1053">1053 </a> virReportError(VIR_ERR_INTERNAL_ERROR, <a name="line1054">1054 </a> _("vCenter IP address %s too big for destination"), <a name="line1055">1055 </a> potentialVCenterIpAddress); <a name="line1056">1056 </a> goto cleanup; <a name="line1057">1057 </a> } <a name="line1058">1058 </a> } else { <a name="line1059">1059 </a> if (esxUtil_ResolveHostname(priv->parsedUri->vCenter, <a name="line1060">1060 </a> vCenterIpAddress, NI_MAXHOST) < 0) { <a name="line1061">1061 </a> goto cleanup; <a name="line1062">1062 </a> } <a name="line1063">1063 </a> <a name="line1064">1064 </a> if (potentialVCenterIpAddress != NULL && <a name="line1065">1065 </a> STRNEQ(vCenterIpAddress, potentialVCenterIpAddress)) { <a name="line1066">1066 </a> virReportError(VIR_ERR_INTERNAL_ERROR, <a name="line1067">1067 </a> _("This host is managed by a vCenter with IP " <a name="line1068">1068 </a> "address %s, but a mismachting vCenter '%s' " <a name="line1069">1069 </a> "(%s) has been specified"), <a name="line1070">1070 </a> potentialVCenterIpAddress, priv->parsedUri->vCenter, <a name="line1071">1071 </a> vCenterIpAddress); <a name="line1072">1072 </a> goto cleanup; <a name="line1073">1073 </a> } <a name="line1074">1074 </a> } <a name="line1075">1075 </a> <a name="line1076">1076 </a> if (esxConnectToVCenter(priv, conn, auth, <a name="line1077">1077 </a> vCenterIpAddress, <a name="line1078">1078 </a> priv->host->ipAddress) < 0) { <a name="line1079">1079 </a> goto cleanup; <a name="line1080">1080 </a> } <a name="line1081">1081 </a> } <a name="line1082">1082 </a> <a name="line1083">1083 </a> priv->primary = priv->host; <a name="line1084">1084 </a> } else { /* VPX */ <a name="line1085">1085 </a> /* Connect to vCenter */ <a name="line1086">1086 </a> if (esxConnectToVCenter(priv, conn, auth, <a name="line1087">1087 </a> conn->uri->server, <a name="line1088">1088 </a> NULL) < 0) { <a name="line1089">1089 </a> goto cleanup; <a name="line1090">1090 </a> } <a name="line1091">1091 </a> <a name="line1092">1092 </a> priv->primary = priv->vCenter; <a name="line1093">1093 </a> } <a name="line1094">1094 </a> <a name="line1095">1095 </a> /* Setup capabilities */ <a name="line1096">1096 </a> priv->caps = esxCapsInit(priv); <a name="line1097">1097 </a> <a name="line1098">1098 </a> if (priv->caps == NULL) { <a name="line1099">1099 </a> goto cleanup; <a name="line1100">1100 </a> } <a name="line1101">1101 </a> <a name="line1102">1102 </a> conn->privateData = priv; <a name="line1103">1103 </a> priv = NULL; <a name="line1104">1104 </a> result = VIR_DRV_OPEN_SUCCESS; <a name="line1105">1105 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:22"></a> (23) Event label: </td> <td>Reached label "cleanup"</td> </tr> </table> <pre><a name="line1106">1106 </a> cleanup: <a name="line1107">1107 </a> esxFreePrivate(&priv); </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:23"></a> (24) Event cond_true: </td> <td>Condition "1", taking true branch</td> </tr> </table> <pre><a name="line1108">1108 </a> VIR_FREE(potentialVCenterIpAddress); <a name="line1109">1109 </a> </pre> <table summary="events" bgcolor=#e0e0e0> <tr><td> <a name="error:24"></a> <a name="error"></a> (25) Event leaked_storage: </td> <td>Variable "priv" going out of scope leaks the storage it points to.</td> </tr> <tr><td>Also see events: </td> <td>[<a href="#error:17">alloc_arg</a>]</td></tr> </table> <pre><a name="line1110">1110 </a> return result; <a name="line1111">1111 </a> } <a name="line1112">1112 </a> <a name="line1113">1113 </a> <a name="line1114">1114 </a> </pre></body> </html>