<div dir="ltr"><div><div><div>Hi Eric,<br><br></div>This should belong to bug-fix, could it be pushed to 1.0.3?<br></div><br></div>Thanks.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Feb 27, 2013 at 11:18 AM, Li Zhang <span dir="ltr"><<a href="mailto:zhlcindy@gmail.com" target="_blank">zhlcindy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com">zhlcindy@linux.vnet.ibm.com</a>><br>
<br>
When getting CPUs' information, it assumes that CPU indexes<br>
are not contiguous. But for ppc64 platform, CPU indexes are not<br>
contiguous because SMT is needed to be disabled, so CPU information<br>
is not right on ppc64 and vpuinfo, vcpupin can't work corretly.<br>
<br>
This patch is to remove the assumption to be compatible with ppc64.<br>
<br>
Test:<br>
4 vcpus are assigned to one VM and execute vcpuinfo command.<br>
<br>
Without patch: There is only one vcpu informaion can be listed.<br>
With patch: All vcpus' information can be listed correctly.<br>
<br>
Signed-off-by: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com">zhlcindy@linux.vnet.ibm.com</a>><br>
---<br>
src/qemu/qemu_monitor_json.c | 7 -------<br>
1 file changed, 7 deletions(-)<br>
<br>
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c<br>
index 9991a0a..e130f8c 100644<br>
--- a/src/qemu/qemu_monitor_json.c<br>
+++ b/src/qemu/qemu_monitor_json.c<br>
@@ -1230,13 +1230,6 @@ qemuMonitorJSONExtractCPUInfo(virJSONValuePtr reply,<br>
goto cleanup;<br>
}<br>
<br>
- if (cpu != i) {<br>
- virReportError(VIR_ERR_INTERNAL_ERROR,<br>
- _("unexpected cpu index %d expecting %d"),<br>
- i, cpu);<br>
- goto cleanup;<br>
- }<br>
-<br>
threads[i] = thread;<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.7.10.1<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</div>