<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 02/27/2013 09:18 PM, TJ wrote:<br>
</div>
<blockquote cite="mid:512EBE77.9050306@iam.tj" type="cite">
<pre wrap="">Signed-off-by: TJ <a class="moz-txt-link-rfc2396E" href="mailto:linux@iam.tj"><linux@iam.tj></a>
---
src/conf/network_conf.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h
index c509915..8400eab 100644
--- a/src/conf/network_conf.h
+++ b/src/conf/network_conf.h
@@ -144,6 +144,10 @@ struct _virNetworkIpDef {
char *bootfile;
virSocketAddr bootserver;
+ /* when false no DHCP server is started */
+ bool dhcp_enabled;
+ /* when true ranges are ignored and a DHCP relay-agent started */
+ bool dhcp_relay;</pre>
</blockquote>
<br>
I think Eric mentioned elsewhere that your patches are *extremely*
small. At least both the data structure, parser, and formatter
changes should go into a single patch. For that matter, this
functionality is small enough that you could put the struct change,
parser change, implementation of the feature in bridge_driver,
makefile and configure changes, AND the documentation addition into
a single patch.<br>
<br>
<blockquote cite="mid:512EBE77.9050306@iam.tj" type="cite">
<pre wrap="">
};
typedef struct _virNetworkForwardIfDef virNetworkForwardIfDef;
@@ -234,6 +238,7 @@ typedef virNetworkObj *virNetworkObjPtr;
struct _virNetworkObj {
virMutex lock;
+ pid_t dhcprelayPid;
pid_t dnsmasqPid;
pid_t radvdPid;
unsigned int active : 1;
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">--
libvir-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre>
</blockquote>
<br>
</body>
</html>