<div dir="ltr"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang <span dir="ltr"><<a href="mailto:zhlcindy@gmail.com" target="_blank">zhlcindy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I also hope that QEMU capabilities depend on the binary by QMP.<br>But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP.<br>
<br>virQEMUCapsInitQMP -> virQEMUCapsProbeQMPObjects -><br>
virQEMUCapsProcessStringFlags(qemuCaps,<br> ARRAY_CARDINALITY(virQEMUCapsObjectTypes),<br> virQEMUCapsObjectTypes,<br> nvalues, values);<br>
<br></div></div></blockquote><div><br></div><div>More information from QEMU:<br><br>I tried to execute "qom-list-types" command, I get a lot of return values including X86 and other platforms.<br></div><div>So this results that most flags may be set in this function.<br>
<br></div><div>More comments?<br><br></div><div>Thanks.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>
<br></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>So, it is not reasonable to set all of these flags for every platform.<br>
</div><div>This is a problem for other non-x86 platforms.<br><br>I saw that capabilities changes a lot since I used 0.10.2 before.<br>
<br></div><div>Could you help look into the code to see this problem? <br></div><div><br></div><div>Thanks a lot. :)<br></div><div>-Li<br></div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">
On Wed, Feb 27, 2013 at 9:36 PM, Jiri Denemark <span dir="ltr"><<a href="mailto:jdenemar@redhat.com" target="_blank">jdenemar@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>On Wed, Feb 27, 2013 at 19:52:22 +0800, Li Zhang wrote:<br>
> From: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com" target="_blank">zhlcindy@linux.vnet.ibm.com</a>><br>
><br>
> Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms.<br>
> Actually, it is only supported for X86.<br>
><br>
> So this patch is to clear the capabilities for non-X86 platforms.<br>
><br>
</div>...<br>
<div>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c<br>
> index 40022c1..ef5c69a 100644<br>
> --- a/src/qemu/qemu_capabilities.c<br>
> +++ b/src/qemu/qemu_capabilities.c<br>
> @@ -1307,8 +1307,11 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {<br>
> { "hda-micro", QEMU_CAPS_HDA_MICRO },<br>
> { "ccid-card-emulated", QEMU_CAPS_CCID_EMULATED },<br>
> { "ccid-card-passthru", QEMU_CAPS_CCID_PASSTHRU },<br>
> +#if defined (__x86_64__) || \<br>
> + defined (__i386__)<br>
> { "piix3-usb-uhci", QEMU_CAPS_PIIX3_USB_UHCI },<br>
> { "piix4-usb-uhci", QEMU_CAPS_PIIX4_USB_UHCI },<br>
> +#endif<br>
> { "usb-ehci", QEMU_CAPS_USB_EHCI },<br>
> { "ich9-usb-ehci1", QEMU_CAPS_ICH9_USB_EHCI1 },<br>
> { "vt82c686b-usb-uhci", QEMU_CAPS_VT82C686B_USB_UHCI },<br>
<br>
</div>NACK. QEMU capabilities depend on the binary we are going to use<br>
(emulator tag in domain XML), they don't depend on host architecture.<br>
<br>
Jirka<br>
</blockquote></div><br><br clear="all"><br></div></div><span class=""><font color="#888888">-- <br><div><br></div>Best Regards<div>-Li</div>
</font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div><br></div>Best Regards<div>-Li</div>
</div></div>