<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Ping, anybody can review this?<br>
<br>
On 28/03/13 19:01, Osier Yang wrote:<br>
</div>
<blockquote cite="mid:51542311.8050308@redhat.com" type="cite">On
28/03/13 19:36, Osier Yang wrote:
<br>
<blockquote type="cite">vcpupin and emulatorpin use same code to
parse the cpulist, this
<br>
abstracts the same code as a helper. Along with various code
style
<br>
fixes, and error improvement (only error "Physical CPU %d
doesn't
<br>
exist" if the specified CPU exceed the range, no "cpulist:
Invalid
<br>
format", see the following for an example of the error prior to
<br>
this patch).
<br>
<br>
% virsh vcpupin 4 0 0-8
<br>
error: Physical CPU 4 doesn't exist.
<br>
error: cpulist: Invalid format.
<br>
---
<br>
tools/virsh-domain.c | 278
++++++++++++++++++++-------------------------------
<br>
1 file changed, 106 insertions(+), 172 deletions(-)
<br>
<br>
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
<br>
index d1e6f9d..0fe2a51 100644
<br>
--- a/tools/virsh-domain.c
<br>
+++ b/tools/virsh-domain.c
<br>
@@ -5460,6 +5460,97 @@ vshPrintPinInfo(unsigned char *cpumaps,
size_t cpumaplen,
<br>
return true;
<br>
}
<br>
+static unsigned char *
<br>
+virParseCPUList(vshControl *ctl, const char *cpulist,
<br>
+ int maxcpu, size_t cpumaplen)
<br>
+{
<br>
<br>
</blockquote>
<br>
I meant vshParseCPUList. With the attached diff squashed in:
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">--
libvir-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre>
</blockquote>
<br>
</body>
</html>