<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">2013/4/17 Daniel P. Berrange <<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>> <blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div class=""><div class="h5">On Fri, Mar 22, 2013 at 05:36:09PM +0800, Chunyan Liu wrote: > Hi, List, > > As the mail I've sent a week before: > <a href="https://www.redhat.com/archives/libvir-list/2013-March/msg00730.html" target="_blank">https://www.redhat.com/archives/libvir-list/2013-March/msg00730.html</a> > I'm willing to push this work forward so that the passthrough APIs > could be reused by qemu driver and libxl driver (which doesn't support > pci passthrough yet and tries to add this function recently), or other > drivers. > > But since this work affacts a lot, I'm not sure if I can control it in > a correct way. I write a draft to describe what I'm considering how to > do, as in the following and in attachment. Hope to get your review, > comment and guidence to improve the work before start coding. Any > feedback will be very appreciated! > > Thanks! > Chunyan > > ------------------------ > DRAFT: > > Write separate module for hostdev passthrough > > 1. Purposes: > > * Move hostdev passthrough APIs from <a href="http://qemu_hostdev.ch" target="_blank">qemu_hostdev.ch</a> to separate module so > that they could be reused by other hypervisors too > > * Maintain global in-use state of hostdevs > > > 2. Module design (draft): > > * New module name: hostdev_driver > > * New module files: <a href="http://hostdev_driver.ch" target="_blank">hostdev_driver.ch</a> <a href="http://hostdev_conf.ch" target="_blank">hostdev_conf.ch</a> > > * New Definitions: > > ## [src/driver.h] > > typedef struct _virHostdevDriver virHostdevDriver; > > typedef virHostdevDriver *virHostdevDriverPtr; > > struct _virHosedevDriver { > const char *name; > virDrvOpen open; > virDrvClose close; > > virDrvPrepareHostdevs prepareHostdevs; > virDrvPreparePciHostdevs preparePciHostdevs; > virDrvprepareUsbHostdevs prepareUsbHostdevs; > virDrvReattachHostdevs reattachHostdevs; > virDrvReattachPciHostdevs reattachPciHostdevs; > virDrvReattachUsbHostdevs reattachUsbHostdevs; > virDrvGetActivePciHostdevList getActivePciHostdevList; > virDrvGetActiveUsbHostdevList getActiveUsbHostdevList; > virDrvGetDomainActivePciHostdevList > getDomainActivePciHostdevList; > virDrvGetDomainActiveUsbHostdevList > getDomainActiveUsbHostdevList; > }; </div></div>This is real overkill - we only need to do the driver table design for things which are public APIs with multiple pluggable implementations. For this scenario, we simply need one single set of internal APIs that any of the stateful hypervisor drivers can directly call into. Basically you just need to define some object to maintain the state eg virHostdevManagerPtr and a method to get the default shared instance of it virHostdevManagerPtr virHostdevManagerGetDefault(); and then the various APIs for interacting with it virHostdevManagerPrepareHostdevs(virHostdevManagerPtr mgr, ....); ...etc.. I'd just put this is all in a src/util/virhostdevmanager.{c,h} file. </blockquote><div> </div><div>Got it. I'm writing it in the way you pointed, as a shared module instead of a driver, as Osier has pointed out too. Thanks for your suggestion about detail, I'll change code to follow that. </div><div> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Regards, Daniel -- |: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :| |: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :| |: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/%7Edanberr/" target="_blank">http://search.cpan.org/~danberr/</a> :| |: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :| </blockquote></div> </div></div>