<div dir="ltr">Hi,<br><div class="gmail_extra"><br>I just spotted a flaw in my OCaml event callback patch. I was hoping to ensure the ocaml bindings build against libvirt 0.9.1 and later. For functions, I remembered to include the usual symbol detection magic. However I forgot that there are also some enums which were added later than 0.9.1 i.e. all of these:</div>
<div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 17, 2013 at 11:16 AM, David Scott <span dir="ltr"><<a href="mailto:scott.dj@gmail.com" target="_blank">scott.dj@gmail.com</a>></span> wrote:</div>
<div class="gmail_quote"><br></div><div class="gmail_quote" style>[snip]</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
+  case VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON:<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

+    cb = VIR_DOMAIN_EVENT_CALLBACK(s_s_i_s_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_CONTROL_ERROR:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(u_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_BLOCK_JOB:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(s_i_i_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_DISK_CHANGE:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(s_s_s_i_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_TRAY_CHANGE:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(s_i_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_PMWAKEUP:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_PMSUSPEND:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_BALLOON_CHANGE:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(i64_callback);<br>
+    break;<br>
+  case VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK:<br>
+    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);<br>
+    break;<br></blockquote><div><br></div><div style>These currently cause the build to break against older libvirts.</div><div style><br></div><div style>I'll rework this and resubmit once I've verified it definitely does work against an older version.</div>
<div style><br></div><div style>Sorry for the noise!</div><div style><br></div><div style>Cheers,</div><div style>Dave</div><div><br></div></div></div></div>