<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/28/2013 03:44 AM, Laine Stump
wrote:<br>
</div>
<blockquote cite="mid:51CD3EF8.2020202@laine.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/28/2013 03:24 AM, Jason Helfman
wrote:<br>
</div>
<blockquote
cite="mid:CAMuy=+gb4XA6zS8882D1Z29-m8U_nPibUbTXf=ijw8TNR2PBGA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="">
<div class="h5">
<div class="gmail_quote">On Thu, Jun 27, 2013 at
11:01 AM, Daniel Veillard <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:veillard@redhat.com"
target="_blank">veillard@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px
0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I have just tagged the release candidate 2 in
git and sent a tarball<br>
to the usual place (rpms are coming):<br>
<a moz-do-not-send="true"
href="ftp://libvirt.org/libvirt/"
target="_blank">ftp://libvirt.org/libvirt/</a><br>
<br>
This includes the end of the patch set from
Laine, and hopefully<br>
it won't require too many other patches. I tried
it and it doesn't<br>
look obviously broken to me, please give it a
try too, especially<br>
for portability :-)<br>
If all goes well the final release should be
next Monday !<br>
<br>
thanks !<br>
<span><font color="#888888"><br>
Daniel<br>
<br>
</font></span></blockquote>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div style="">So far, I am getting linker errors for
FreeBSD here:</div>
<div style=""> <a moz-do-not-send="true"
href="https://redports.org/buildarchive/20130628070800-42595/">https://redports.org/buildarchive/20130628070800-42595/</a></div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
Sigh. I see the problem. Patch coming up...<br>
</blockquote>
<br>
<br>
Okay, I pushed the following patch:<br>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/archives/libvir-list/2013-June/msg01171.html">https://www.redhat.com/archives/libvir-list/2013-June/msg01171.html</a><br>
<br>
Can you apply this patch locally to the source tar and re-run your
test build to make sure nothing else is broken (since there won't be
another rc before release)? If there are still problems, you can
find us in #virt on irc.oftc.net.<br>
<br>
<br>
<br>
commit a757822233f707c4ed75986f5903e26e40f3cdfa<br>
Author: Laine Stump <a class="moz-txt-link-rfc2396E" href="mailto:laine@laine.org"><laine@laine.org></a><br>
Date: Fri Jun 28 04:00:54 2013 -0400<br>
<br>
util: fix build error on non-Linux systems<br>
<br>
Building on FreeBSD had this linker error:<br>
<br>
/work/a/ports/devel/libvirt/work/libvirt-1.1.0/src/.libs/libvirt.so:<br>
undefined reference to `virPCIDeviceAddressParse'<br>
<br>
This was caused by the new use of virPCIDeviceAddressParse in a<br>
portion of virpci.c that wasn't linux-only (in commit 72c029d8).
The<br>
problem was that virPCIDeviceAddressParse had originally been
defined<br>
inside #ifdef _linux (because it was only used by another
function<br>
that was inside the same ifdef).<br>
<br>
The solution is to move it out to the part of virpci.c that is<br>
compiled on all platforms.<br>
<br>
(Because the portion that was "moved" was 40-50 lines, but only
moved<br>
up by 15 lines, the diff for the patch is less than
non-informative -<br>
rather than showing that part that I moved, it shows the bit
that was<br>
previously before the moved part, and now sits *after* it.)<br>
<br>
<br>
</body>
</html>