<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=utf-8" http-equiv=Content-Type>
<STYLE>
BLOCKQUOTE {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px; MARGIN-LEFT: 2em
}
OL {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
UL {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
P {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
BODY {
LINE-HEIGHT: 1.5; FONT-FAMILY: 微软雅黑; COLOR: #000000; FONT-SIZE: 10.5pt; 36719: ; 38597: ; 40657:
}
</STYLE>
<META name=GENERATOR content="MSHTML 8.00.7601.17514"></HEAD>
<BODY style="MARGIN: 10px">
<DIV>Hi Eric, </DIV>
<DIV>On 2013-09-18 00:12 , <A href="mailto:eblake@redhat.com">Eric
Blake</A> wrote:</DIV>
<DIV>
<TABLE width="100%">
<TBODY>
<TR>
<TD width="100%">
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV>On 09/17/2013 09:56 AM, hzguanqiang@gmail.com wrote:</DIV>
<DIV>> From: Guan Qiang <hzguanqiang@corp.netease.com></DIV>
<DIV>> </DIV>
<DIV>> The patches add support for setting/getting blkio read/write
bps/iops</DIV>
<DIV>> throttle per-device with blkio cgroup.</DIV>
<DIV> </DIV>
<DIV>Closer. This time, your cover letter lists:</DIV>
<DIV>Message-id: <52387bc4.8223440a.6e6a.163b@mx.google.com></DIV>
<DIV> </DIV>
<DIV>which is valid; but your patches list:</DIV>
<DIV>References: <1379433398-21795-1-git-send-email-y></DIV>
<DIV>In-Reply-To: <1379433398-21795-1-git-send-email-y></DIV>
<DIV> </DIV>
<DIV>which is still not a valid email reference (according to the
RFCs,</DIV>
<DIV>References: and In-Reply-To: fields should contain an @), and
therefore</DIV>
<DIV>are not threaded to the cover letter.</DIV>
<DIV> </DIV>
<DIV>Note how confused the list archiver got when trying to decipher
your mail:</DIV>
<DIV>https://www.redhat.com/archives/libvir-list/2013-September/thread.html#01007</DIV>
<DIV> </DIV>
<DIV>For an example of threading done right, see:</DIV>
<DIV>https://www.redhat.com/archives/libvir-list/2013-September/thread.html#00982</DIV>
<DIV> </DIV>
<DIV>There, the cover letter uses:</DIV>
<DIV>Message-id: <cover.1379428840.git.mprivozn@redhat.com></DIV>
<DIV> </DIV>
<DIV>and each patch contains:</DIV>
<DIV>References: <cover.1379428840.git.mprivozn@redhat.com></DIV>
<DIV>In-Reply-To: <cover.1379428840.git.mprivozn@redhat.com></DIV>
<DIV> </DIV>
<DIV>When working on git mail configurations, it is often a good idea to
use</DIV>
<DIV>'git send-email --to=YOUR@EMAIL' and send the patches to yourself
first,</DIV>
<DIV>to check if you have properly configured git, before sending to the
list.</DIV>
<DIV> </DIV>
<DIV>At any rate, please don't resend just because of this (3 attempts
is</DIV>
<DIV>enough for one day; the patches are available, even if we have to
hunt a</DIV>
<DIV>bit for them); just remember it for you next future patch
submission :)</DIV>
<DIV> </DIV></BLOCKQUOTE>
<DIV> </DIV>
<DIV>I've tried to send the patches to my own email before I send-email to
libvir-list.</DIV>
<DIV>
<DIV>But How do I confirm it's ok? Make sure the patch series with
the same</DIV>
<DIV>Message-id, References and In-Reply-To
info?</DIV></DIV></TD></TR></TBODY></TABLE></DIV>
<DIV> </DIV>
<DIV>And What're the whole libvirt development workflow? After I submit a
patch,</DIV>
<DIV><SPAN>What will happen following? Is there anyone assigned to review
it? If modification need</SPAN></DIV>
<DIV><SPAN>to be made for the patches, should submitter send new patch email? Or
If the patch is not </SPAN></DIV>
<DIV><SPAN>so interested, will it be ignored? And what's the
requirement for a patch to be signed off?</SPAN></DIV>
<DIV><SPAN></SPAN> </DIV>
<DIV><SPAN>Thanks</SPAN></DIV>
<DIV><SPAN>------------------ <BR>Best
regards!<BR>GuanQiang</DIV></SPAN>
<DIV>14:30:25</DIV></BODY></HTML>