<div dir="ltr">Yes, 'goto cleanup' would be better. </div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/25 Hongwei Bi <span dir="ltr"><<a href="mailto:hwbi2008@gmail.com" target="_blank">hwbi2008@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Yes, 'goto cleanup' would be better. </div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">2013/9/25 Ján Tomko <span dir="ltr"><<a href="mailto:jtomko@redhat.com" target="_blank">jtomko@redhat.com</a>></span><br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">On 09/25/2013 07:49 AM, Hongwei Bi wrote:<br>
><br>
><br>
> ---<br>
>  tools/virsh-domain.c |    4 +++-<br>
>  1 files changed, 3 insertions(+), 1 deletions(-)<br>
><br>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c<br>
> index 856e888..f6d4edd 100644<br>
> --- a/tools/virsh-domain.c<br>
> +++ b/tools/virsh-domain.c<br>
> @@ -4487,8 +4487,10 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)<br>
>      if (!(dom = vshCommandOptDomain(ctl, cmd, &name)))<br>
>          return false;<br>
><br>
> -    if (vshCommandOptStringReq(ctl, cmd, "file", &to) < 0)<br>
> +    if (vshCommandOptStringReq(ctl, cmd, "file", &to) < 0) {<br>
> +        virDomainFree(dom);<br>
>          return false;<br>
> +    }<br>
<br>
'goto cleanup' would do the same and it's easier to read.<br>
<br>
Alternatively, if we moved vshCommandOptStringReq before vshCommandOptDomain,<br>
'return false' would be enough.<br>
<br>
Jan<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>