<div dir="ltr">Hi Jan, Cole, <div><br></div><div>Could you please reviewing my patch ?</div><div><br></div><div>Thanks,</div><div>Shiva<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 30, 2013 at 1:37 PM, Shivaprasad bhat <span dir="ltr"><<a href="mailto:shivaprasadbhat@gmail.com" target="_blank">shivaprasadbhat@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">Hi,</span><br style="font-family:arial,sans-serif;font-size:13px">
<br style="font-family:arial,sans-serif;font-size:13px"><span style="font-family:arial,sans-serif;font-size:13px">Could someone please help reviewing the patch ?</span><br style="font-family:arial,sans-serif;font-size:13px">

<br style="font-family:arial,sans-serif;font-size:13px"><span style="font-family:arial,sans-serif;font-size:13px">Thanks and Regards,</span><br style="font-family:arial,sans-serif;font-size:13px"><span style="font-family:arial,sans-serif;font-size:13px">Shiva</span><div style="font-family:arial,sans-serif;font-size:13px">

</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 28, 2013 at 2:50 PM, Shivaprasad G Bhat <span dir="ltr"><<a href="mailto:shivaprasadbhat@gmail.com" target="_blank">shivaprasadbhat@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the disk types. Pseries platform needs this to appear as SCSI instead of IDE.<br>


<br>
Signed-off-by: Shivaprasad G Bhat <<a href="mailto:sbhat@linux.vnet.ibm.com" target="_blank">sbhat@linux.vnet.ibm.com</a>><br>
---<br>
 src/qemu/qemu_domain.c |   11 +++++++++++<br>
 1 file changed, 11 insertions(+)<br>
<br>
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c<br>
index b8aec2d..df06c13 100644<br>
--- a/src/qemu/qemu_domain.c<br>
+++ b/src/qemu/qemu_domain.c<br>
@@ -827,6 +827,12 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,<br>
     if (dev->type == VIR_DOMAIN_DEVICE_DISK) {<br>
         virDomainDiskDefPtr disk = dev->data.disk;<br>
<br>
+        if ((def->os.arch == VIR_ARCH_PPC64) &&<br>
+            def->os.machine && STREQ(def->os.machine, "pseries") &&<br>
+            (disk->bus == VIR_DOMAIN_DISK_BUS_IDE)) {<br>
+            disk->bus = VIR_DOMAIN_DISK_BUS_SCSI;<br>
+        }<br>
+<br>
         /* both of these require data from the driver config */<br>
         if (driver && (cfg = virQEMUDriverGetConfig(driver))) {<br>
             /* assign default storage format and driver according to config */<br>
@@ -868,6 +874,11 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,<br>
         (def->os.arch == VIR_ARCH_S390 || def->os.arch == VIR_ARCH_S390X))<br>
         dev->data.chr->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO;<br>
<br>
+    if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&<br>
+        dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_IDE &&<br>
+        def->os.machine && STREQ(def->os.machine, "pseries"))<br>
+        dev->data.controller->type = VIR_DOMAIN_CONTROLLER_TYPE_SCSI;<br>
+<br>
     /* set the default USB model to none for s390 unless an address is found */<br>
     if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&<br>
         dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_USB &&<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div>