<div dir="ltr">Thanks Cole. There are some changes to the patch. Next patch I'll try to add.<div><br></div><div>Thanks,</div><div>Shiva</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 14, 2013 at 7:31 PM, Cole Robinson <span dir="ltr"><<a href="mailto:crobinso@redhat.com" target="_blank">crobinso@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 11/14/2013 04:11 AM, Shivaprasad bhat wrote:<br>
> Thanks Cole.<br>
><br>
> The change is to correct the IDE disk type to SCSI on pseries systems for<br>
> domxml-from-native.<br>
><br>
> Here is the test case and results.<br>
><br>
> sh# cat cmd.txt<br>
</div>> *qemu-system-ppc64 -M pseries -m 4096 -nographic -enable-kvm -hda<br>
> /data/images/rhel70.qcow2 -name rhel70 -cdrom<br>
> /data/iso/RHEL-7.0-20130306.0-Server-ppc64-dvd1.iso -boot d -vnc :30*<br>
><br>
> sh# ./run tools/*virsh domxml-from-native qemu-argv cmd.txt*<br>
<div class="im">> <domain type='kvm'><br>
> <name>rhel70</name><br>
> <uuid>eae019ae-a155-4dd8-be21-f9738b6aedea</uuid><br>
> <memory unit='KiB'>4194304</memory><br>
> <currentMemory unit='KiB'>4194304</currentMemory><br>
> <vcpu placement='static'>1</vcpu><br>
> <os><br>
> <type arch='ppc64' machine='pseries'>hvm</type><br>
> <boot dev='cdrom'/><br>
> </os><br>
> <clock offset='utc'/><br>
> <on_poweroff>destroy</on_poweroff><br>
> <on_reboot>restart</on_reboot><br>
> <on_crash>destroy</on_crash><br>
> <devices><br>
> <emulator>qemu-system-ppc64</emulator><br>
> <disk type='file' device='disk'><br>
> <driver name='qemu' type='raw'/><br>
> <source file='/data/images/rhel70.qcow2'/><br>
</div>> * <target dev='hda' bus='scsi'/> //----> ide is<br>
> changed to SCSI*<br>
<div class="im">> <address type='drive' controller='0' bus='0' target='0' unit='0'/><br>
> </disk><br>
> <disk type='file' device='cdrom'><br>
> <driver name='qemu' type='raw'/><br>
> <source file='/data/iso/RHEL-7.0-20130306.0-Server-ppc64-dvd1.iso'/><br>
</div>> * <target dev='hdc' bus='scsi'/> //----> ide is changed<br>
> to SCSI*<br>
<div class="im">> <readonly/><br>
> <address type='drive' controller='0' bus='1' target='0' unit='0'/><br>
> </disk><br>
</div>> * <controller type='scsi' index='0'/> //----> Controller ide<br>
> also changed to SCSI*<br>
<div class="im">> <controller type='usb' index='0'/><br>
> <controller type='pci' index='0' model='pci-root'/><br>
> <input type='mouse' bus='ps2'/><br>
> <graphics type='vnc' port='5930' autoport='no' listen=''><br>
> <listen type='address' address=''/><br>
> </graphics><br>
> <video><br>
> <model type='cirrus' vram='9216' heads='1'/><br>
> </video><br>
> <memballoon model='virtio'/><br>
> </devices><br>
> </domain><br>
> sh#<br>
><br>
<br>
</div>Thanks, but what I meant was to add an automated test case under the tests/<br>
directory that demonstrates what is actually fixed. See<br>
tests/qemuargv2xmltest.c, will require appropriate *.args and *.xml files in<br>
tests/qemuxml2argvdata/<br>
<br>
- Cole<br>
<div class="im"><br>
><br>
><br>
> On Thu, Nov 14, 2013 at 3:02 AM, Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a><br>
</div><div class="im">> <mailto:<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>>> wrote:<br>
><br>
> On 11/13/2013 04:31 PM, Shivaprasad bhat wrote:<br>
> > Hi Jan, Cole,<br>
> ><br>
> > Could you please reviewing my patch ?<br>
> ><br>
> > Thanks,<br>
> > Shiva<br>
> ><br>
><br>
> I'd recommend adding a test case that demonstrates what exactly this is<br>
> changing.<br>
><br>
> - Cole<br>
><br>
> ><br>
> > On Wed, Oct 30, 2013 at 1:37 PM, Shivaprasad bhat<br>
> <<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a> <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a>><br>
</div>> > <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a> <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a>>>><br>
<div class="im">> wrote:<br>
> ><br>
> > Hi,<br>
> ><br>
> > Could someone please help reviewing the patch ?<br>
> ><br>
> > Thanks and Regards,<br>
> > Shiva<br>
> ><br>
> ><br>
> > On Mon, Oct 28, 2013 at 2:50 PM, Shivaprasad G Bhat<br>
> > <<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a> <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a>><br>
</div><div class="im">> <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a> <mailto:<a href="mailto:shivaprasadbhat@gmail.com">shivaprasadbhat@gmail.com</a>>>> wrote:<br>
> ><br>
> > The bus type IDE being enum Zero, the bus type on pseries system<br>
> > appears as IDE for all the disk types. Pseries platform needs<br>
> this to<br>
> > appear as SCSI instead of IDE.<br>
> ><br>
> > Signed-off-by: Shivaprasad G Bhat <<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a><br>
> <mailto:<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a>><br>
</div>> > <mailto:<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a> <mailto:<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a>>>><br>
<div><div class="h5">> > ---<br>
> > src/qemu/qemu_domain.c | 11 +++++++++++<br>
> > 1 file changed, 11 insertions(+)<br>
> ><br>
> > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c<br>
> > index b8aec2d..df06c13 100644<br>
> > --- a/src/qemu/qemu_domain.c<br>
> > +++ b/src/qemu/qemu_domain.c<br>
> > @@ -827,6 +827,12 @@<br>
> > qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,<br>
> > if (dev->type == VIR_DOMAIN_DEVICE_DISK) {<br>
> > virDomainDiskDefPtr disk = dev->data.disk;<br>
> ><br>
> > + if ((def->os.arch == VIR_ARCH_PPC64) &&<br>
> > + def->os.machine && STREQ(def->os.machine, "pseries") &&<br>
> > + (disk->bus == VIR_DOMAIN_DISK_BUS_IDE)) {<br>
> > + disk->bus = VIR_DOMAIN_DISK_BUS_SCSI;<br>
> > + }<br>
> > +<br>
> > /* both of these require data from the driver config */<br>
> > if (driver && (cfg = virQEMUDriverGetConfig(driver))) {<br>
> > /* assign default storage format and driver<br>
> according to<br>
> > config */<br>
> > @@ -868,6 +874,11 @@<br>
> > qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,<br>
> > (def->os.arch == VIR_ARCH_S390 || def->os.arch ==<br>
> > VIR_ARCH_S390X))<br>
> > dev->data.chr->targetType =<br>
> > VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO;<br>
> ><br>
> > + if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&<br>
> > + dev->data.controller->type ==<br>
> VIR_DOMAIN_CONTROLLER_TYPE_IDE &&<br>
> > + def->os.machine && STREQ(def->os.machine, "pseries"))<br>
> > + dev->data.controller->type =<br>
> VIR_DOMAIN_CONTROLLER_TYPE_SCSI;<br>
> > +<br>
> > /* set the default USB model to none for s390 unless an address<br>
> > is found */<br>
> > if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&<br>
> > dev->data.controller->type ==<br>
> VIR_DOMAIN_CONTROLLER_TYPE_USB &&<br>
> ><br>
> > --<br>
> > libvir-list mailing list<br>
> > <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> <mailto:<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>><br>
</div></div>> <mailto:<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> <mailto:<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>>><br>
> > <a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a><br>
> ><br>
> ><br>
> ><br>
><br>
><br>
<br>
</blockquote></div><br></div>