<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=utf-8" http-equiv=Content-Type>
<STYLE>
BLOCKQUOTE {
        MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px; MARGIN-LEFT: 2em
}
OL {
        MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
UL {
        MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
P {
        MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
BODY {
        LINE-HEIGHT: 1.5; FONT-FAMILY: 微软雅黑; COLOR: #000000; FONT-SIZE: 10.5pt; 36719: ; 38597: ; 40657: 
}
</STYLE>

<META name=GENERATOR content="MSHTML 8.00.7601.17514"></HEAD>
<BODY style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt">
<DIV>I've tested the patchset successful with virsh command for both kvm and lxc 
vm.</DIV>
<DIV>Details are as following:</DIV>
<DIV 
style="FONT-SIZE: 8pt">--------------------------------------KVM-------------------------</DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# virsh version</DIV>
<DIV style="FONT-SIZE: 8pt">Compiled against library: libvirt 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Using library: libvirt 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Using API: QEMU 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Running hypervisor: QEMU 1.7.0</DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV></DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# virsh blkiotune kvm</DIV>
<DIV 
style="FONT-SIZE: 8pt">weight         : 
500</DIV>
<DIV style="FONT-SIZE: 8pt">device_weight  : </DIV>
<DIV style="FONT-SIZE: 8pt">device_read_iops: </DIV>
<DIV style="FONT-SIZE: 8pt">device_write_iops: </DIV>
<DIV style="FONT-SIZE: 8pt">device_read_bps: </DIV>
<DIV style="FONT-SIZE: 8pt">device_write_bps: </DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# virsh blkiotune kvm 
--device-weights /dev/vda,250 --device-read-iops /dev/vda,1234567 
--device-write-iops /dev/vda,2345678 --device-read-bps /dev/vda,123456789 
--device-write-bps /dev/vda,234567890  --config 
--live                     
</DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# virsh blkiotune kvm</DIV>
<DIV 
style="FONT-SIZE: 8pt">weight         : 
500</DIV>
<DIV style="FONT-SIZE: 8pt">device_weight  : /dev/vda,250</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_iops: /dev/vda,1234567</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_iops: /dev/vda,2345678</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_bps: /dev/vda,123456789</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_bps: /dev/vda,234567890</DIV></DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/kvm.libvirt-qemu/blkio.weight_device </DIV>
<DIV style="FONT-SIZE: 8pt">254:0 
250           </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/kvm.libvirt-qemu/blkio.throttle.read_bps_device 
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 123456789</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/kvm.libvirt-qemu/blkio.throttle.read_iops_device  
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 1234567</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/kvm.libvirt-qemu/blkio.throttle.write_bps_device      
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 234567890</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/kvm.libvirt-qemu/blkio.throttle.write_iops_device  
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 2345678</DIV>
<DIV> </DIV>
<DIV>---------------------------- lxc ----------------------------------</DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# vir version</DIV>
<DIV style="FONT-SIZE: 8pt">Compiled against library: libvirt 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Using library: libvirt 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Using API: LXC 1.2.0</DIV>
<DIV style="FONT-SIZE: 8pt">Running hypervisor: LXC 3.10.11</DIV></DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# vir blkiotune lxc 
--device-weights /dev/vda,250 --device-read-iops /dev/vda,1234567 
--device-write-iops /dev/vda,2345678 --device-read-bps /dev/vda,123456789 
--device-write-bps /dev/vda,234567890  --config --live </DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# vir blkiotune lxc</DIV>
<DIV 
style="FONT-SIZE: 8pt">weight         : 
500</DIV>
<DIV style="FONT-SIZE: 8pt">device_weight  : /dev/vda,250</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_iops: /dev/vda,1234567</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_iops: /dev/vda,2345678</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_bps: /dev/vda,123456789</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_bps: /dev/vda,234567890</DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# vir blkiotune lxc 
--device-weights /dev/vda,270 --device-read-iops /dev/vda,111111111 
--device-write-iops /dev/vda,22222222 --device-read-bps /dev/vda,333336789 
--device-write-bps /dev/vda,5555555  --config 
--live                                       
</DIV>
<DIV style="FONT-SIZE: 8pt"> </DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# vir blkiotune lxc</DIV>
<DIV 
style="FONT-SIZE: 8pt">weight         : 
500</DIV>
<DIV style="FONT-SIZE: 8pt">device_weight  : /dev/vda,270</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_iops: /dev/vda,111111111</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_iops: /dev/vda,22222222</DIV>
<DIV style="FONT-SIZE: 8pt">device_read_bps: /dev/vda,333336789</DIV>
<DIV style="FONT-SIZE: 8pt">device_write_bps: /dev/vda,5555555</DIV></DIV>
<DIV> </DIV>
<DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/lxc.libvirt-lxc/blkio.weight_device </DIV>
<DIV style="FONT-SIZE: 8pt">254:0 270</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/lxc.libvirt-lxc/blkio.throttle.read_iops_device 
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 111111111</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/lxc.libvirt-lxc/blkio.throttle.write_iops_device     
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 22222222</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/lxc.libvirt-lxc/blkio.throttle.read_bps_device        
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 333336789</DIV>
<DIV style="FONT-SIZE: 8pt">root@debian:~/images# cat 
/sys/fs/cgroup/blkio/machine/lxc.libvirt-lxc/blkio.throttle.write_bps_device   
</DIV>
<DIV style="FONT-SIZE: 8pt">254:0 5555555</DIV></DIV>
<DIV> </DIV></DIV>
<DIV>On 2013-12-03 16:44 , <A href="mailto:gaofeng@cn.fujitsu.com">Gao 
feng</A> wrote:</DIV>
<DIV>
<TABLE width="100%">
  <TBODY>
  <TR>
    <TD width="100%">
      <BLOCKQUOTE 
      style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
        <DIV>On 12/03/2013 10:48 AM, hzguanqiang@corp.netease.com wrote:</DIV>
        <DIV>> On 2013-12-02 14:47 , Gao feng 
        <mailto:gaofeng@cn.fujitsu.com> wrote:</DIV>
        <DIV>> </DIV>
        <DIV>>     Right now, libvirt only supports the 
        cfq based blkio cgorup,</DIV>
        <DIV>>     this means if the block devices 
        doesn't use cfq scheduler, the</DIV>
        <DIV>>     blkio cgroup will loss effect.</DIV>
        <DIV>>      </DIV>
        <DIV>>     This patchset adds the throttle blkio 
        cgroup support for libvirt,</DIV>
        <DIV>>     intoduces four elements for domain 
        configuration and extend the</DIV>
        <DIV>>     virsh command blkiotune.</DIV>
        <DIV>> </DIV>
        <DIV>>  </DIV>
        <DIV>> intoduces/introduces/s</DIV>
        <DIV>>  </DIV>
        <DIV> </DIV>
        <DIV> </DIV>
        <DIV>Oh, my hand slip. Thanks!</DIV>
        <DIV> </DIV>
        <DIV>BTW, chould you help to review or test this patchset?</DIV>
        <DIV>It runs well in my test box.</DIV>
        <DIV> </DIV>
        <DIV>Thanks.</DIV></BLOCKQUOTE></TD></TR></TBODY></TABLE></DIV>
<DIV> </DIV>
<DIV><SPAN>
<DIV style="FONT-FAMILY: verdana; FONT-SIZE: 10pt">
<DIV>------------------     <BR>Best 
regards!<BR>GuanQiang</DIV></DIV></SPAN></DIV>
<DIV>12:46:48</DIV></BODY></HTML>