<div dir="ltr"><div><pre class="" id="comment_text_2" style="white-space:pre-wrap;word-wrap:break-word;width:50em;color:rgb(0,0,0)">Incorrect usage of virAsprintf and vmware-vmx reports to stderr.</pre></div>--- <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1036248">https://bugzilla.redhat.com/show_bug.cgi?id=1036248</a><br>
<div><br></div><div><div>diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c</div><div>index 027e245..477dc72 100644</div><div>--- a/src/vmware/vmware_conf.c</div><div>+++ b/src/vmware/vmware_conf.c</div><div>
@@ -271,17 +271,17 @@ vmwareExtractVersion(struct vmware_driver *driver)</div><div> </div><div>     switch (driver->type) {</div><div>         case VMWARE_DRIVER_PLAYER:</div><div>-            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmplayer"))</div>
<div>+            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmplayer") < 0)</div><div>                 goto cleanup;</div><div>             break;</div><div> </div><div>         case VMWARE_DRIVER_WORKSTATION:</div>
<div>-            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware"))</div><div>+            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware") < 0)</div><div>                 goto cleanup;</div>
<div>             break;</div><div> </div><div>         case VMWARE_DRIVER_FUSION:</div><div>-            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx"))</div><div>+            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx") < 0)</div>
<div>                 goto cleanup;</div><div>             break;</div><div> </div><div>@@ -293,6 +293,9 @@ vmwareExtractVersion(struct vmware_driver *driver)</div><div> </div><div>     cmd = virCommandNewArgList(bin, "-v", NULL);</div>
<div>     virCommandSetOutputBuffer(cmd, &outbuf);</div><div>+    </div><div>+    // OS X 10.9.1 and some earlier ver: vmware-vmx reports ver to stderr   </div><div>+    virCommandSetErrorBuffer(cmd, &outbuf);</div>
<div> </div><div>     if (virCommandRun(cmd, NULL) < 0)</div><div>         goto cleanup;</div></div><div><br></div></div>