<div dir="ltr"><div><div><div>I agree, there is no harm in adding an option of configuration, different setup configurations require different timeout values. </div>my setup was 8 servers booted with PXE boot and running on nfs rootfs, with 8 vms on each. </div>when I tried to start all of them together the bottle neck was the network and it takes about 5 minutes till they all start. I think a good solution will include changes in qemu's behavior, but the solution that I suggested is much better than the current state. </div>we would be very happy not to manage our own version of libvirt. Silence gives consent? </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Jan 16, 2014 at 5:49 PM, Martin Kletzander <<a href="mailto:mkletzan@redhat.com" target="_blank">mkletzan@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping? Can we at least change the default [2/2] or should I send a v2 for that one? Martin <div class="HOEnZb"><div class="h5"> On Fri, Jan 10, 2014 at 04:27:40PM +0100, Martin Kletzander wrote: > On Fri, Jan 10, 2014 at 02:18:37PM +0000, Daniel P. Berrange wrote: > > On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: > > > From: Pavel Fux <<a href="mailto:pavel@stratoscale.com">pavel@stratoscale.com</a>> > > > > > > Adding an option to change monitor socket opening timeout > > > the current default is 3 seconds and in some cases it's not enough > > > > > > Signed-off-by: Pavel Fux <<a href="mailto:pavel@stratoscale.com">pavel@stratoscale.com</a>> > > > Signed-off-by: Martin Kletzander <<a href="mailto:mkletzan@redhat.com">mkletzan@redhat.com</a>> > > > --- > > > > > > Notes: > > > I modified the description in the config file, made the use of the > > > opaque argument in qemuMonitorOpen and rebased it on current master. > > > > > > I also added the config options in augeas test to make the 'make > > > check' pass. > > > > IMHO we shouldn't add this config parameter. This kind of parameter is > > basically saying "our code doesn't work by default, set this to fix it" > > which is just horrible behaviour. Further more an admin won't even find > > out about this until the worst possible time. Just increase the default > > timeout if we need to. Even better would be to figure out how we can > > properly fix this to avoid any need for timeout at all. > > > > The same can be said about e.g. audio-related options in the config > file or (when going to extremes) debug logs. Yes, there might be > problems and this is a way how admins/users can check where a > particular problem might be. And the very fact that we need to change > this variable now does in fact proves that this might need another > change in the future. Having this particular value configurable is > merely a _option_ for admins/users and I see no drawback at all in it. > > As Rich suggested (and Cole copied), check out the number of hits for: > <a href="https://www.google.co.uk/search?q=" target="_blank">https://www.google.co.uk/search?q=</a>"monitor+socket+did+not+show+up" > > Many of them are related to the domains having managed-save, but since > nobody looked for a root cause of it (as I know of), this might be > related to this very problem. > > Does this mean ACK to [2/2] and NACK to [1/2] then? > > Martin > > P.S.: I also forgot to mention that this might most probably resolve > these bugs: > > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=892273" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=892273</a> > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=895901" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=895901</a> > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=987088" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=987088</a> > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1051364" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1051364</a> > > > Regards, > > Daniel > > -- > > |: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :| > > |: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :| > > |: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :| > > |: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :| > > > > -- > > libvir-list mailing list > > <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> > > <a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a> > -- > libvir-list mailing list > <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a> </div></div></blockquote></div> </div>