<div dir="ltr">Is this patch series ready to be pushed? Without it, libvirt cannot create VMs in ppc64 hosts with a working VNC console (unless you use the qemu command line pass-through hack), this affects both oVirt and VDSM, since they rely on graphical terminals to work.<div>
<div><br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 19, 2013 at 5:50 AM, Li Zhang <span dir="ltr"><<a href="mailto:zhlcindy@gmail.com" target="_blank">zhlcindy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Li Zhang <<a href="mailto:zhlcindy@linux.vnet.ibm.com">zhlcindy@linux.vnet.ibm.com</a>><br>
<br>
This patchset is to add keyboard input device.<br>
<br>
For PPC64, it doesn't support a default keyboard device when the graphic<br>
is enabled. Libvirt supports QEMU command line as "-device VGA" which<br>
won't create any keyboard device for it. So it requires libvirt to add<br>
a default USB keyboard device for it.<br>
<br>
This patchset is to add keyboard input device and a default USB keyboard<br>
for PPC64.<br>
<br>
The related discussion in QEMU community:<br>
<a href="http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html" target="_blank">http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html</a><br>
<br>
Li Zhang (6):<br>
conf: Add a keyboard input device type<br>
conf: Add one interface to add default input devices.<br>
conf: Remove PS2 mouse device for non-X86 platforms<br>
qemu_cap: Add USB keyboard capability<br>
qemu: parse qemu command line for USB keyboard<br>
Add a default USB keyboard and USB mouse for PPC64<br>
<br>
v5 -> v4:<br>
* Add PS/2 KBD definition in XML file. (Daniel.P.Berrange)<br>
* Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange)<br>
* Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange)<br>
<br>
v4 -> v3:<br>
* Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko).<br>
<br>
v3 -> v2:<br>
* Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange)<br>
* Remove PS2 mouse device for non-X86 platforms.<br>
* Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko)<br>
* Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko)<br>
* Fix several typos. (Jan Tomoko)<br>
* Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko)<br>
<br>
v2 -> v1:<br>
* change ifs to switch clause.<br>
* reconstruct the patches<br>
<br>
docs/schemas/domaincommon.rng | 1 +<br>
src/conf/domain_conf.c | 92 ++++++++++++++--------<br>
src/conf/domain_conf.h | 5 ++<br>
src/libvirt_private.syms | 1 +<br>
src/qemu/qemu_capabilities.c | 2 +<br>
src/qemu/qemu_capabilities.h | 1 +<br>
src/qemu/qemu_command.c | 41 +++++++---<br>
src/qemu/qemu_domain.c | 23 +++++-<br>
src/util/virarch.h | 2 +<br>
src/xenxs/xen_sxpr.c | 27 +++++--<br>
src/xenxs/xen_xm.c | 30 +++++--<br>
tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 +<br>
tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 +<br>
tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 +<br>
tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 +<br>
tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 2 +<br>
tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 +<br>
tests/qemuhelptest.c | 8 ++<br>
.../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 3 +-<br>
.../qemuxml2argv-pseries-usb-kbd.args | 9 +++<br>
.../qemuxml2argv-pseries-usb-kbd.xml | 19 +++++<br>
tests/qemuxml2argvtest.c | 3 +<br>
22 files changed, 212 insertions(+), 62 deletions(-)<br>
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args<br>
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.8.2.1<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a><br>
</font></span></blockquote></div><br></div>