<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-12 23:11 GMT+08:00 Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Fri, Mar 07, 2014 at 06:53:12PM +0800, Chunyan Liu wrote:<br>
> Check NULL parameter inputs<br>
><br>
> Signed-off-by: Chunyan Liu <<a href="mailto:cyliu@suse.com">cyliu@suse.com</a>><br>
> ---<br>
>  src/util/virhostdev.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++<br>
>  1 file changed, 57 insertions(+)<br>
><br>
> diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c<br>
> index 577de48..5f61bfc 100644<br>
> --- a/src/util/virhostdev.c<br>
> +++ b/src/util/virhostdev.c<br>
> @@ -468,6 +468,11 @@ virHostdevPreparePciHostdevs(virHostdevManagerPtr hostdev_mgr,<br>
>      size_t i;<br>
>      int ret = -1;<br>
><br>
> +    if (!nhostdevs)<br>
> +        return 0;<br>
<br>
</div>This is reasonable because it is an expected case.<br>
<div class=""><br>
> +    if (hostdev_mgr == NULL)<br>
> +        return -1;<br>
<br>
</div>This is something that should never happen except by programmer<br>
error, since this is allocated right at libvirtd startup and<br>
then never changed thereafter.<br>
<br>
It is preferrable to use ATTRIBUTE_NONNULL() in the header<br>
file for these kind of things.<br></blockquote><div><br></div><div>Will update.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Regards,<br>
Daniel<br>
<span class="HOEnZb"><font color="#888888">--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a>      -o-    <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a>              -o-             <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a>       -o-         <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a>       -o-       <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
<br>
</font></span></blockquote></div><br></div></div>