<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-12 23:12 GMT+08:00 Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Mar 07, 2014 at 06:53:09PM +0800, Chunyan Liu wrote:<br>
> Signed-off-by: Chunyan Liu <<a href="mailto:cyliu@suse.com">cyliu@suse.com</a>><br>
> ---<br>
>  src/libvirt_private.syms |  8 ++++----<br>
>  src/qemu/qemu_hostdev.c  | 16 +++++++--------<br>
>  src/util/virhostdev.c    | 52 ++++++++++++++++++++++++------------------------<br>
>  src/util/virhostdev.h    | 40 ++++++++++++++++++-------------------<br>
>  4 files changed, 58 insertions(+), 58 deletions(-)<br>
><br>
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms<br>
> index 5bb529c..e7d9d56 100644<br>
> --- a/src/libvirt_private.syms<br>
> +++ b/src/libvirt_private.syms<br>
> @@ -1297,10 +1297,10 @@ virHostdevManagerGetDefault;<br>
>  virHostdevPciNodeDeviceDetach;<br>
>  virHostdevPciNodeDeviceReAttach;<br>
>  virHostdevPciNodeDeviceReset;<br>
> -virHostdevPreparePCIDevices;<br>
> -virHostdevPrepareSCSIDevices;<br>
> -virHostdevPrepareUSBDevices;<br>
> -virHostdevReAttachPCIDevices;<br>
> +virHostdevPreparePciHostdevs;<br>
> +virHostdevPrepareScsiHostdevs;<br>
> +virHostdevPrepareUsbHostdevs;<br>
> +virHostdevReAttachPciHostdevs;<br>
>  virHostdevReAttachScsiHostdevs;<br>
>  virHostdevReAttachUsbHostdevs;<br>
>  virHostdevUpdateActivePciHostdevs;<br>
<br>
</div></div>IMHO this is fixing the wrong side of the inconsistency.<br>
<br>
PCI, USB and SCSI are all abbreviations, so using capitalization<br>
is correct. We should instead fix the Pci, Usb and Scsi names.<br></blockquote><div><br></div><div>Thanks. I'll update.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Regards,<br>
Daniel<br>
<span class="HOEnZb"><font color="#888888">--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a>      -o-    <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a>              -o-             <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a>       -o-         <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a>       -o-       <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
<br>
</font></span></blockquote></div><br></div></div>