<div dir="ltr">Thinks for fixing this! I am suffering compiling error with hvsupport (yet have no idea why) for several days.</div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-08-21 0:44 GMT+08:00 Michal Privoznik <span dir="ltr"><<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 20.08.2014 18:31, Peter Krempa wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 08/20/14 18:20, Michal Privoznik wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Since vbox driver rewrite the virDriver structure init moved from<br>
vbox_tmpl.c into vbox_common.c. However, our <a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a> script<br>
doesn't count with that. It still parses vbox_tmp.c and looks for<br>
virDriver structure which is not found there anymore. As a result,<br>
at hvsupport page is seems like vbox driver doesn't support<br>
anything.<br>
<br>
Signed-off-by: Michal Privoznik <<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>><br>
---<br>
docs/<a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a> | 2 +-<br>
src/vbox/vbox_driver.c | 2 +-<br>
2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/docs/<a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a> b/docs/<a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a><br>
index f8483f9..34ba599 100755<br>
--- a/docs/<a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a><br>
+++ b/docs/<a href="http://hvsupport.pl" target="_blank">hvsupport.pl</a><br>
@@ -28,7 +28,7 @@ my %groupheaders = (<br>
my @srcs;<br>
find({<br>
wanted => sub {<br>
- if (m!$srcdir/.*/\w+_(driver|<u></u>tmpl|monitor|hal|udev)\.c$!) {<br>
+ if (m!$srcdir/.*/\w+_(driver|<u></u>common|tmpl|monitor|hal|udev)\<u></u>.c$!) {<br>
</blockquote>
<br>
tmpl will need to be purged once the vbox driver rewrite is done<br>
</blockquote>
<br></div>
Yeah, I'm keeping it until the time the storage and network drivers are rewritten too. I saw Taowei proposed patches, but haven't reviewed them yet.<div class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
push @srcs, $_ if $_ !~ /vbox_driver\.c/;<br>
}<br>
}, no_chdir => 1}, $srcdir);<br>
diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c<br>
index f0c05fe..498be71 100644<br>
--- a/src/vbox/vbox_driver.c<br>
+++ b/src/vbox/vbox_driver.c<br>
@@ -210,5 +210,5 @@ static virDrvOpenStatus dummyConnectOpen(virConnectPtr conn,<br>
static virDriver vboxDriverDummy = {<br>
VIR_DRV_VBOX,<br>
"VBOX",<br>
- .connectOpen = dummyConnectOpen,<br>
+ .connectOpen = dummyConnectOpen, /* 0.6.3 */<br>
};<br>
<br>
</blockquote>
<br>
ACK<br>
<br>
Peter<br>
<br>
</blockquote>
<br>
<br></div>
Pushed now, thanks!<span class="HOEnZb"><font color="#888888"><br>
<br>
Michal</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/<u></u>mailman/listinfo/libvir-list</a><br>
</div></div></blockquote></div><br></div>