<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi John With your patch and latest qemu-kvm, I can't start guest. # rpm -q qemu-kvm qemu-kvm-1.5.3-70.el7.x86_64 # virsh start test error: Failed to start domain test error: internal error: unable to execute QEMU command 'query-iothreads': The command query-iothreads has not been found <div class="moz-cite-prefix">On 09/16/2014 08:55 AM, Eric Blake wrote: </div> <blockquote cite="mid:54178A80.8030401@redhat.com" type="cite"> <pre wrap="">On 09/15/2014 06:13 PM, John Ferlan wrote: </pre> <blockquote type="cite"> <pre wrap="">Well I guess it happens to everyone - hopefully only once though... </pre> </blockquote> <pre wrap=""> Yep, the brown bag of shame lets you learn from mistakes rather quickly :) </pre> <blockquote type="cite"> <pre wrap=""> The IOThreads code really messed up a few things - git bisection for the build is broken as of 5f6ad32c733a3bd158938aecabb0508a434ece95, but that's resolved by 938fb12fad6d15c9fdb73f998c4e0ec1e278721f which adds the 'niothreadspin && iothreadspin' definitions. Secondarily it seems things got worse, because guests weren't able to be started because of a very bad logic error (<= 0 vs. < 0 and specific check that 0 is "OK" (meaning no IOThreads). How that got by own self testing I'm still not quite sure, but it did and it's a mea culpa for that. Anyway, patch 1 fixes the running issue... Patch 2 fixes some spacing issues that Eric pointed out privately (prefer "i + 1" vs. "i+1"). Patch 3 just makes sure to use the right cgroup setup/init parameters since there is no "iothread0" John Ferlan (3): qemu: Fix iothreads issue qemu_cgroup: Adjust spacing around incrementor qemu: Fix call in qemuDomainSetNumaParamsLive for virCgroupNewIOThread </pre> </blockquote> <pre wrap=""> Thanks for the fast fixes. I confirm that patch 1 fixes the regression in starting my dummy transient domain. ACK series. </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">-- libvir-list mailing list <a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre> </blockquote> <pre class="moz-signature" cols="72">-- Regards shyu</pre> </body> </html>