<div dir="ltr">Thank you, Michal. I will read your comments carefully. It is great examples for me to learn more about the project.</div><div class="gmail_extra"><br><div class="gmail_quote">2014-10-03 16:48 GMT+08:00 Michal Privoznik <span dir="ltr"><<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 02.10.2014 05:30, Taowei wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This seriers of patches rewrite the vbox network driver.<br>
<br>
Diff from v2:<br>
*Seperate the network driver from the domain driver.<br>
*Prevent vbox code from being compiled too many times<br>
when building network driver.<br>
<br>
Taowei (14):<br>
vbox: Interfaces for register per parties<br>
vbox: Rewrite vboxNetworkOpen<br>
vbox: Rewrite vboxNetworkClose<br>
vbox: Rewrite vboxConnectNumOfNetworks<br>
vbox: Rewrite vboxConnectListNetworks<br>
vbox: Rewrite vboxConnectNumOfDefinedNetwork<u></u>s<br>
vbox: Rewrite vboxConnectListDefinedNetworks<br>
vbox: Rewrite vboxNetworkLookupByUUID<br>
vbox: Rewrite vboxNetworkLookupByName<br>
vbox: Rewrite vboxNetworkDefineCreateXML<br>
vbox: Rewrite vboxNetworkUndefineDestroy<br>
vbox: Rewrite vboxNetworkCreate<br>
vbox: Rewrite vboxNetworkGetXMLDesc<br>
vbox: New network driver<br>
<br>
po/POTFILES.in | 1 +<br>
src/Makefile.am | 16 +-<br>
src/vbox/vbox_common.c | 70 +-<br>
src/vbox/vbox_common.h | 16 +<br>
src/vbox/vbox_driver.c | 55 +-<br>
src/vbox/{vbox_install_api.h => vbox_get_driver.h} | 9 +-<br>
src/vbox/vbox_network.c | 1050 ++++++++++++++++<br>
src/vbox/vbox_tmpl.c | 1261 +++++---------------<br>
src/vbox/vbox_uniformed_api.h | 52 +<br>
9 files changed, 1523 insertions(+), 1007 deletions(-)<br>
rename src/vbox/{vbox_install_api.h => vbox_get_driver.h} (79%)<br>
create mode 100644 src/vbox/vbox_network.c<br>
<br>
</blockquote>
<br></div></div>
I'm fixing all the small nits I've found, ACKing and pushing.<br>
Awesome job - the compilation is somewhat faster again. Thanks!<span class="HOEnZb"><font color="#888888"><br>
<br>
Michal<br>
</font></span></blockquote></div><br></div>