<html><body><div>Hi,</div><div><br></div><div>I was trying to pass ip address to scripts/vif-bridge by putting <ip address=""/> in guest config xml file, however, I found that libxlMakeNic(<span style="line-height: 1.5;" data-mce-style="line-height: 1.5;">which located in libxl/libxl_conf.c:956</span><span style="line-height: 1.5;" data-mce-style="line-height: 1.5;">) doesn't set x_nic->ip. So I patched myself but I'm not so sure about </span><span style="line-height: 1.5;">VIR_DOMAIN_NET_TYPE_ETHERNET. </span><span style="line-height: 1.5;">It seems like vif-route, correct? </span></div><div><span style="line-height: 1.5;"><br></span></div><div><span style="line-height: 1.5;">Here is my patch:</span></div><div><span style="line-height: 1.5;" data-mce-style="line-height: 1.5;"><br></span></div><div><span data-mce-style="line-height: 1.5;"><div>diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c</div><div>index 0555b91..0effc59 100644</div><div>--- a/src/libxl/libxl_conf.c</div><div>+++ b/src/libxl/libxl_conf.c</div><div>@@ -1047,10 +1047,18 @@ libxlMakeNic(virDomainDefPtr def,</div><div> if (VIR_STRDUP(x_nic->bridge,</div><div> virDomainNetGetActualBridgeName(l_nic)) < 0)</div><div> return -1;</div><div>- /* fallthrough */</div><div>+ if (VIR_STRDUP(x_nic->script, l_nic->script) < 0)</div><div>+ return -1;</div><div>+ if (VIR_STRDUP(x_nic->ip, l_nic->data.bridge.ipaddr) < 0)</div><div>+ return -1;</div><div>+ break;</div><div> case VIR_DOMAIN_NET_TYPE_ETHERNET:</div><div> if (VIR_STRDUP(x_nic->script, l_nic->script) < 0)</div><div> return -1;</div><div>+ if (VIR_STRDUP(x_nic->ip, l_nic->data.ethernet.ipaddr) < 0)</div><div>+ return -1;</div><div>+ if (VIR_STRDUP(x_nic->gatewaydev, l_nic->data.ethernet.dev) < 0)</div><div>+ return -1;</div><div> break;</div><div> case VIR_DOMAIN_NET_TYPE_NETWORK:</div><div style=""> {</div></span></div><div><br></div><div><span style="font-family: 'Helvetica Neue', Helvetica, sans-serif;" data-mce-style="font-family: 'Helvetica Neue', Helvetica, sans-serif;"> <span style="line-height: 16.7999992370605px; white-space: pre;" data-mce-style="line-height: 16.7999992370605px; white-space: pre;">Regards, </span> </span></div><div><span style="font-family: 'Helvetica Neue', Helvetica, sans-serif;" data-mce-style="font-family: 'Helvetica Neue', Helvetica, sans-serif;"> <span style="line-height: 16.7999992370605px; white-space: pre;" data-mce-style="line-height: 16.7999992370605px; white-space: pre;"> <br> </span> </span></div><div><span style="font-family: 'Helvetica Neue', Helvetica, sans-serif;" data-mce-style="font-family: 'Helvetica Neue', Helvetica, sans-serif;"> <span style="line-height: 16.7999992370605px; white-space: pre;" data-mce-style="line-height: 16.7999992370605px; white-space: pre;">Jihoon</span> </span></div></body></html>