<html><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><META name="Author" content="Novell GroupWise WebAccess"><style type="text/css"> body p { margin: 0px; } </style></head><body style='font-family: Helvetica, Arial, sans-serif; font-size: 13px; '><div id="GroupWiseSection_1423149412000_lma@suse.com_B118D7016C3D0000BC7D000BCD69755F_" class="GroupWiseMessageBody"><div> </div>>>>> "Daniel P. Berrange" <berrange@redhat.com> 2015-2-4 下午 23:10 >>> >On Wed, Feb 04, 2015 at 02:21:18AM -0500, Laine Stump wrote: >> On 02/03/2015 11:47 AM, Michal Privoznik wrote: >> > On 02.02.2015 15:08, Lin Ma wrote: >> >> * Get the live state info of a virtual network through netcf in networkGetXMLDesc. >> >> * Add --system flag for net-dumpxml to show the live state info. >> >> * Check the live state info in net-destroy. >> >> * Add --force flag for net-destroy to forcibly destroy the virtual network. >> >> * Check the transient interfaces info in iface-unbridge. >> >> >> >> --- >> >> Lin Ma (3): >> >> bridge_driver: Return the live state info of a given virtual network >> >> virsh: prevent destroying a in-used network for net-destroy >> >> virsh: prevent removing a in-used bridge for iface-unbridge >> >> >> >> include/libvirt/libvirt-network.h | 1 + >> >> src/Makefile.am | 3 + >> >> src/network/bridge_driver.c | 141 ++++++++++++++++++++++++++++++++++- >> >> src/network/bridge_driver_platform.h | 7 ++ >> >> tests/Makefile.am | 4 + >> >> tools/virsh-interface.c | 25 ++++++- >> >> tools/virsh-network.c | 62 ++++++++++++++- >> >> tools/virsh.pod | 8 +- >> >> 8 files changed, 241 insertions(+), 10 deletions(-) >> >> >> > So I've spent some time thinking about this. I don't really like the >> > idea of producing completely different XML (it doesn't even have >> > <network> as its root element!). But I see what you're trying to </network><network>>> > achieve. How about putting the bridged interfaces into the network </network><network>>> > definition (on request signalized by a flag, of course). </network><network>>> </network><network>>> I think that if we're going to add the list of connected guest devices </network><network>>> to a network's status, that it should just always be there - adding a </network><network>>> new flag for every little bit of different status sets a bad precedent </network><network>>> and sets us up to have an infinitely increasing number of flags. </network><network>>> </network><network>>> Like I mentioned in my response to one of the patches, I think this </network><network>>> information is better gathered and maintained by the bridge driver as </network><network>>> guests connect to / disconnect from a network; this avoids the necessity </network><network>>> of dragging netcf into the picture and allows much better information - </network><network>>> the name of the domain using each interface can be included. </network>> <network>>You know if this checking for guests were done in the virNetworkDestroy </network><network>>API implementation in src/network/bridge_driver.c, instead of in </network><network>>virsh, then we would not need any of this code for extending the XML </network><network>>nor parsing it in virsh. We could simply check the number of connections </network><network>>which is something we have directly available internally. So 95% of this </network><network>>patch series would go away :-C I'm sad...... :-), Anyway, Because we keep the original behaviour of net-destroy, So we keep iface-unbridge no changes as well, Then droping this patch series makes sense. </network></div></body></html>