<html><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><META name="Author" content="Novell GroupWise WebAccess"><style type="text/css"> body p { margin: 0px; } </style></head><body style='font-family: Helvetica, Arial, sans-serif; font-size: 13px; '> <div id="GroupWiseSection_1423150122000_lma@suse.com_B118D7016C3D0000BC7D000BCD69755F_" class="GroupWiseMessageBody">>>>> "Daniel P. Berrange" <berrange@redhat.com> 2015-2-4 下午 17:17 >>> >On Mon, Feb 02, 2015 at 10:08:21PM +0800, Lin Ma wrote: >> It constructs a temporary static config of the network, Obtains all of >> attached interfaces information through netcf, Then removes the config. >> >> Signed-off-by: Lin Ma <lma@suse.com> </lma@suse.com><lma@suse.com>>> --- </lma@suse.com><lma@suse.com>>> include/libvirt/libvirt-network.h | 1 + </lma@suse.com><lma@suse.com>>> src/Makefile.am | 3 + </lma@suse.com><lma@suse.com>>> src/network/bridge_driver.c | 141 ++++++++++++++++++++++++++++++++++- </lma@suse.com><lma@suse.com>>> src/network/bridge_driver_platform.h | 7 ++ </lma@suse.com><lma@suse.com>>> tests/Makefile.am | 4 + </lma@suse.com><lma@suse.com>>> 5 files changed, 155 insertions(+), 1 deletion(-) </lma@suse.com>> <lma@suse.com>>So, IIUC, the point of this change is to display a list of all the TAP </lma@suse.com><lma@suse.com>>devices attached to a network. I'm not entirely convinced this is the </lma@suse.com><lma@suse.com>>r</lma@suse.com><lma@suse.com>ight approach to take. Also do we want to limit this to reporting of </lma@suse.com><lma@suse.com>>devices inside bridges. It could be equally useful to see a list of </lma@suse.com><lma@suse.com>>macvtap devices associated with a physical NIC. </lma@suse.com>Obtaining a list of macvtap devices associated with a physical NIC, It's a good idea. I intend to implement this api, also implement a new virsh subcommand to show these information to user. If you agreed with my thought, Then what are the proper api name and virsh subcommand name you suggest? and what about the output format? <lma@suse.com>>Modifying the XML to include the list of VIFs is certainly one options, </lma@suse.com><lma@suse.com>>but I'm not sure it is necceessarily the best. As Laine points out this </lma@suse.com><lma@suse.com>>is a output only attribute - not something you can feed in with the XML </lma@suse.com><lma@suse.com>>when defining the network. </lma@suse.com>> <lma@suse.com>>Perhaps we want to have an actual API for this - a virNetworkListPorts </lma@suse.com><lma@suse.com>>which returns a list of associated devices (of any type) from guests. </lma@suse.com><lma@suse.com>>Or perhaps we should be reporting a list of virDomainPtr's that are </lma@suse.com><lma@suse.com>>attached to the network, or perhaps even both. </lma@suse.com></div></body></html>