<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 17, 2015 at 8:47 AM, Laine Stump <span dir="ltr"><<a href="mailto:laine@laine.org" target="_blank">laine@laine.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 02/16/2015 08:46 PM, Antoni Segura Puimedon wrote:<br>
> From: Antoni Segura Puimedon <<a href="mailto:toni@midokura.com">toni@midokura.com</a>><br>
><br>
> Midonet is an opensource virtual networking that over lays the IP<br>
> network between hypervisors. Currently, such networks can be made<br>
> with the openvswitch virtualport type. With this patch, one will<br>
> be able to setup such configurations by binding vNICs to Midonet<br>
> overlay ports.<br>
><br>
> Signed-off-by: Antoni Segura Puimedon <<a href="mailto:toni@midokura.com">toni@midokura.com</a>><br>
> ---<br>
> <a href="http://configure.ac" target="_blank">configure.ac</a> | 4 ++<br>
> docs/schemas/networkcommon.rng | 12 +++++<br>
> src/Makefile.am | 1 +<br>
> src/conf/domain_conf.h | 1 +<br>
> src/conf/netdev_vport_profile_conf.c | 3 +-<br>
> src/libvirt_private.syms | 5 ++<br>
> src/qemu/qemu_hotplug.c | 25 +++++++---<br>
> src/qemu/qemu_process.c | 13 +++--<br>
> src/util/virnetdevmidonet.c | 97 ++++++++++++++++++++++++++++++++++++<br>
> src/util/virnetdevmidonet.h | 37 ++++++++++++++<br>
> src/util/virnetdevtap.c | 11 ++--<br>
> src/util/virnetdevvportprofile.c | 1 +<br>
> src/util/virnetdevvportprofile.h | 5 +-<br>
> 13 files changed, 197 insertions(+), 18 deletions(-)<br>
> create mode 100644 src/util/virnetdevmidonet.c<br>
> create mode 100644 src/util/virnetdevmidonet.h<br></div></div></blockquote><div><br>Hi Laine! <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<br>
</div></div>I haven't checked the rest for completeness yet, but thought I'd point<br>
out in advance that you need to also document the new type in<br>
<a href="http://formatdomain.html.in" target="_blank">formatdomain.html.in</a>.<br></blockquote><div><br>Oops, I left it for later when doing the patch and submitted it without getting<br>to it. I'll re-send ;-) <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also, I don't see any changes here to the network configuration to<br>
support a network of this type. That can be a second step though. (A<br>
very useful thing - it would allow migration of a guest from a host<br>
using a standard Linux host bridge to a host using this new network<br>
connection type, for example).<br></blockquote><div><br>Sounds interesting, how would the migration work for the required interfaceid<br>in midonet? Does openvswitch do this thanks to the virtualport interfaceid<br>generation?<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
You may also need to go through the hypervisor drivers other than qemu<br>
and put in explicit checks for your new virtualport type and log an<br>
UNSUPPORTED message if it's encountered.<br></blockquote><div><br>True! Is there a lot of adoption of the lxc driver? Cause maybe I can add<br>support as well for that one.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Another thing - for awhile now everyone has been putting the<br>
config/doc/schema changes in one patch, the utility functions in a<br>
second, and the glue that ties them together in qemu/lxc/etc in a third.<br>
That can make it easier to review, test, and also in the case that some<br>
other new feature might use the same utility functions it makes it<br>
easier to backport one feature without needing to backport the other.<br>
etc etc.<br></blockquote><div><br>That makes a lot of sense, I'll split the patch accordingly. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
I'll go through the code that that's here in the morning.<br></blockquote><div><br>Thanks a lot for the help last night and for these comments!<br><br>Toni <br></div></div><br></div></div>