<div dir="ltr">Actually I messed that up slightly on the case.  My C is a bit rusty:<div><br></div><div><div>diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c</div><div>--- libvirt-1.2.13.orig/src/qemu/qemu_migration.c<span class="" style="white-space:pre"> </span>2015-02-23 22:04:12.000000000 -0800</div><div>+++ libvirt-1.2.13/src/qemu/qemu_migration.c<span class="" style="white-space:pre">    </span>2015-03-18 13:55:45.873322477 -0700</div><div>@@ -1507,9 +1507,12 @@</div><div>             flags |= VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA;</div><div>         break;</div><div> </div><div>+    case VIR_STORAGE_TYPE_NETWORK:</div><div>+        ret = 0;</div><div>+        goto cleanup;</div><div>+        break;</div><div>     case VIR_STORAGE_TYPE_BLOCK:</div><div>     case VIR_STORAGE_TYPE_DIR:</div><div>-    case VIR_STORAGE_TYPE_NETWORK:</div><div>     case VIR_STORAGE_TYPE_NONE:</div><div>     case VIR_STORAGE_TYPE_LAST:</div><div>         virReportError(VIR_ERR_INTERNAL_ERROR,</div></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 18, 2015 at 1:42 PM, Noel Burton-Krahn <span dir="ltr"><<a href="mailto:noel@pistoncloud.com" target="_blank">noel@pistoncloud.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Michal,<br></div><div><br></div><div>We're testing libvirt-1.2.13 and found it failed to live migrate domains with attached network drives.  The change to libvirt was made in commit cf54c606, announced here:  <a href="https://www.redhat.com/archives/libvir-list/2014-November/msg01053.html" target="_blank">https://www.redhat.com/archives/libvir-list/2014-November/msg01053.html</a></div><div><br></div><div>It's not necessary to precreate network drives.  They're created during nova live migration in openstack.  How about this patch?</div><div><br></div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c</div></div><div><div>--- libvirt-1.2.13.orig/src/qemu/qemu_migration.c<span style="white-space:pre-wrap">  </span>2015-02-23 22:04:12.000000000 -0800</div></div><div><div>+++ libvirt-1.2.13/src/qemu/qemu_migration.c<span style="white-space:pre-wrap">   </span>2015-03-18 12:18:14.137990147 -0700</div></div><div><div>@@ -1510,6 +1510,9 @@</div></div><div><div>     case VIR_STORAGE_TYPE_BLOCK:</div></div><div><div>     case VIR_STORAGE_TYPE_DIR:</div></div><div><div>     case VIR_STORAGE_TYPE_NETWORK:</div></div><div><div>+        ret = 0;</div></div><div><div>+        goto cleanup;</div></div><div><div>+        break;</div></div><div><div>     case VIR_STORAGE_TYPE_NONE:</div></div><div><div>     case VIR_STORAGE_TYPE_LAST:</div></div><div><div>         virReportError(VIR_ERR_INTERNAL_ERROR,</div></div></blockquote><div><br></div><div><br></div><div><div>Cheers,</div><div>--</div><div>Noel Burton-Krahn</div><div>Sr, Distributed Systems Engineer</div><div>Piston Cloud Computing</div><div><br></div></div></div>
</blockquote></div><br></div>